Opened 4 months ago

Last modified 4 months ago

#2667 new Request

improve fld_read time management

Reported by: gsamson Owned by: gsamson
Priority: low Milestone:
Component: SBC Version: trunk
Severity: minor Keywords: fld_read
Cc: greffray, rbourdal, jchanut Branch review:
MP ready?: Task progress:

Description

Context

"fld_read" routine always considers that the field timestep is centred on the middle of the time window separating two successive fld_read calls.
This is usually true when the field is a time-averaged variable valid at the middle of the corresponding time bounds.
But in the case of instantaneous fields, they are valid at the exact timestep of the fld_read call. Consequently, fld_read shifts the field valid timestep by half its frequency, which is wrong and can significantly offset atmospheric forcings for example.

Proposal

introduce a new argument in fld_read structure to specify whether the field read by fld_read is (time-)averaged or instantaneous, and shift field valid timestep accordingly in fld_read.

Commit History (0)

(No commits)

Attachments (1)

patch.diff (5.1 KB) - added by ohuziy 4 months ago.
commit diff

Download all attachments as: .zip

Change History (2)

Changed 4 months ago by ohuziy

commit diff

comment:1 Changed 4 months ago by ohuziy

There is already code to handle this case in our version of the model (implemented by Michael Dunphy). I have added the patch as an attachment. Not sure what would be a proper way to propagate this upstream..

Note: See TracTickets for help on using tickets.