Opened 6 months ago

Closed 6 months ago

#2690 closed Defect (fixed)

Sign convention of the isf freshwater fluxes

Reported by: mathiot Owned by: mathiot
Priority: low Milestone:
Component: MULTIPLE Version: trunk
Severity: minor Keywords:
Cc: Branch review:
MP ready?: Task progress:

Description

Context

Point 2 of #2669: The freshwater flux (qfwf or fwfisf) is negative when melting. It does not really follow the nemo general rule of having positive runoffs.

Analysis


Recommendation

  • change sign through out the code to have flux from isf to oce and not the other way around
  • check impact on isf input file

Test : it should not change the results (run.stat) and should not change the WED025 output except for the sign

Commit History (3)

ChangesetAuthorTimeChangeLog
15003mathiot2021-06-16T12:21:35+02:00

ticket #2690: sette successful ; update branch to head of trunk

15001mathiot2021-06-16T11:30:56+02:00

ticket #2690: change sign convention of isf fluxes, long name of output and code comments. No changes in WED025 and ISOMIP+ results (output changed because of convention changed, trunk + branch output = 0.0)

14996mathiot2021-06-15T19:55:39+02:00

ticket #2690: create branch

Change History (6)

comment:1 Changed 6 months ago by mathiot

In 14996:

ticket #2690: create branch

comment:2 Changed 6 months ago by mathiot

In 15001:

ticket #2690: change sign convention of isf fluxes, long name of output and code comments. No changes in WED025 and ISOMIP+ results (output changed because of convention changed, trunk + branch output = 0.0)

comment:3 Changed 6 months ago by mathiot

Full sette results:

(base) pmathiot@login1:/scratch/cnt0021/egi6035/pmathiot/NEMO/branches/ticket2690_consign_isf/sette$ ./sette_rpt.sh 

Current code is : NEMO/branches/2021/ticket2690_consign_isf @ r14996  ( last change @ r14996 )

SETTE validation report generated for : 

       NEMO/branches/2021/ticket2690_consign_isf @ r14996 (last changed revision)

       on occigen arch file


!!---------------1st pass------------------!!

   !----restart----!   
WGYRE_PISCES_ST              run.stat    restartability  passed :  14996
WGYRE_PISCES_ST              tracer.stat restartability  passed :  14996
WORCA2_ICE_PISCES_ST         run.stat    restartability  passed :  14996
WORCA2_ICE_PISCES_ST         tracer.stat restartability  passed :  14996
WORCA2_OFF_PISCES_ST         tracer.stat restartability  passed :  14996
WAMM12_ST                    run.stat    restartability  passed :  14996
WORCA2_SAS_ICE_ST            run.stat    restartability  passed :  14996
WAGRIF_DEMO_ST               run.stat    restartability  passed :  14996
WWED025_ST                   run.stat    restartability  passed :  14996
WISOMIP+_ST                  run.stat    restartability  passed :  14996
WOVERFLOW_ST                 run.stat    restartability  passed :  14996
WLOCK_EXCHANGE_ST            run.stat    restartability  passed :  14996
WVORTEX_ST                   run.stat    restartability  passed :  14996
WICE_AGRIF_ST                run.stat    restartability  passed :  14996
WSWG_ST                      directory                  MISSING :  14996

   !----repro----!   
WGYRE_PISCES_ST              run.stat    reproducibility passed :  14996
WGYRE_PISCES_ST              tracer.stat reproducibility passed :  14996
WORCA2_ICE_PISCES_ST         run.stat    reproducibility passed :  14996
WORCA2_ICE_PISCES_ST         tracer.stat reproducibility passed :  14996
WORCA2_OFF_PISCES_ST         tracer.stat reproducibility passed :  14996
WAMM12_ST                    run.stat    reproducibility passed :  14996
WORCA2_SAS_ICE_ST            run.stat    reproducibility passed :  14996
WORCA2_ICE_OBS_ST            run.stat    reproducibility passed :  14996
WAGRIF_DEMO_ST               run.stat    reproducibility FAILED :  14996  (results are different after  17     time steps)
WWED025_ST                   run.stat    reproducibility passed :  14996
WISOMIP+_ST                  run.stat    reproducibility passed :  14996
WVORTEX_ST                   run.stat    reproducibility passed :  14996
WICE_AGRIF_ST                run.stat    reproducibility passed :  14996
WSWG_ST                      directory                  MISSING :  14996

   !----agrif check----!   
ORCA2 AGRIF vs ORCA2 NOAGRIF run.stat    unchanged  -    passed :  14996 14996

   !----result comparison check----!   

check result differences between :
VALID directory : /scratch/cnt0021/egi6035/pmathiot/NEMO/branches/ticket2690_consign_isf/NEMO_VALIDATION at rev 14996
and
REFERENCE directory : /scratch/cnt0021/egi6035/pmathiot/NEMO/trunk/NEMO_VALIDATION at rev 14985

WGYRE_PISCES_ST       run.stat    files are identical  
WGYRE_PISCES_ST       tracer.stat files are identical  
WORCA2_ICE_PISCES_ST  run.stat    files are identical  
WORCA2_ICE_PISCES_ST  tracer.stat files are identical  
WORCA2_OFF_PISCES_ST  tracer.stat files are identical  
WAMM12_ST             run.stat    files are identical  
WORCA2_SAS_ICE_ST     run.stat    files are identical  
WAGRIF_DEMO_ST        run.stat    files are identical  
WWED025_ST            run.stat    files are identical  
WISOMIP+_ST           run.stat    files are identical  
WVORTEX_ST            run.stat    files are identical  
WICE_AGRIF_ST         run.stat    files are identical  
WOVERFLOW_ST          run.stat    files are identical  
WLOCK_EXCHANGE_ST     run.stat    files are identical  
WSWG_ST                      REFERENCE directory at 14985 is MISSING

comment:4 Changed 6 months ago by mathiot

Comments on the sette results:

  • AGRIF failed as in the the trunk and results are the same between my branch and my reference trunk version ⇒ not an issue with my branch
  • SWG is not run and tested as in my reference trunk version ⇒ not an issue with my branch
  • all other results are positive

comment:5 Changed 6 months ago by mathiot

In 15003:

ticket #2690: sette successful ; update branch to head of trunk

comment:6 Changed 6 months ago by mathiot

  • Resolution set to fixed
  • Status changed from new to closed

Fix committed to the trunk at revision r15004 (wrong ticket number in the commit message)

Note: See TracTickets for help on using tickets.