New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2706 (ISF: bug in option cn_gammablk=vel_stab) – NEMO

#2706 closed Bug (fixed)

ISF: bug in option cn_gammablk=vel_stab

Reported by: clem Owned by: systeam
Priority: low Milestone:
Component: ICB Version: trunk
Severity: minor Keywords:
Cc:

Description

For ISF when using option cn_gammablk=vel_stab, one must use the variable qoce in the subroutine isfcav_gammats but it is only calculated afterwards in isfcav_mlt. So, one must initialize qoce before its use in isfcav_gammats.
In addition the initialization of qoce_b is probablement not the right one. It is written as the sensible flux while it should be the latent flux (see isfcav_mlt routine).

Fix:
change this line:

      IF (TRIM(cn_gammablk) == 'vel_stab' ) zqoce_b (:,:) = ptsc(:,:,jp_tem) * rho0_rcp ! last time step total heat fluxes (to speed up convergence)

by this one:

      IF ( TRIM(cn_gammablk) == 'vel_stab' ) THEN
         zqoce(:,:) = -pqfwf(:,:) * rLfusisf ! 
         zqh_b(:,:) =  ptsc(:,:,jp_tem) * rho0_rcp ! last time step total heat fluxes (to speed up convergence)
      ENDIF

And make the convergence criterion on qoce+qhc qnd not only qoce:

            zerr = MAXVAL(ABS(zqhc(:,:)+zqoce(:,:) - zqh_b(:,:)))

I'll do the changes and commit them because this routine just does not pass debug right now but it needs to be checked out by people who know (I guess Pierre)

Commit History (2)

ChangesetAuthorTimeChangeLog
15084clem2021-07-05T21:48:42+02:00

trunk ISF: correct option cn_gammablk=vel_stab as much as I understand it and remove some useless lbc_lnk. Ref ticket is #2706

15082clem2021-07-05T18:25:26+02:00

trunk: 1st try to solve problems with ISF option cn_gammablk=vel_stab (partly associated with ticket #2706)

Change History (3)

comment:1 Changed 13 months ago by clem

In 15082:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:2 Changed 13 months ago by clem

In 15084:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:3 Changed 10 months ago by clem

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.