New URL for NEMO forge!

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2726 (Bug in trcsink) – NEMO

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2726 closed Bug (fixed)

Bug in trcsink

Reported by: aumont Owned by: aumont
Priority: low Milestone:
Component: TOP Version: trunk
Severity: major Keywords:



trcsink handles the sinking of particles. In case, sinking speed is high enough so that the CFL criterion is violated, a time splitting approach is used. The number of necesseray iterations is automatically computed and may be capped at a maximum value to avoid a very high computing cost in specific cases.


Two bugs have been identified :
1) the number of iteration is incorrectly computed. The INT instruction is used which is rounding the number of iterations to the nearest lower integer. INT() + 1 should be used instead.
2) The time splitting approach is inactive. No iteration on the number of necessary iterations is performed. Sinking speeds are reduced instead when necessary. This is equivalent to specifying nitermax to 1.


This module should be rewritten correcting for the bugs listed above.

Commit History (2)


bugfix in TOP/TRP/trcsink.F90, see ticket #2726


bug fix #2726

Change History (2)

comment:1 Changed 3 years ago by aumont

  • Resolution set to fixed
  • Status changed from new to closed

In 15291:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:2 Changed 3 years ago by cetlod

In 15325:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found
Note: See TracTickets for help on using tickets.