Incomplete initialisation in diahth.F90

[acc]

Context

Misleading output can be generated from dia_hth with some combinations of output diagnostics

Analysis

The code section which initialises the temporary arrays is contained within a:

       IF( iom_use( 'mlddzt' ) .OR. iom_use( 'mldr0_3' ) .OR. iom_use( 'mldr0_1' ) ) THEN

statement but it is possible to request other diagnostics whilst omitting any of these three. In this case the arrays are not initialised and results can contain random values.
See, for example:
​https://nemo-ocean.discourse.group/t/4-0-x-bug-in-variable-output-mldr10-3/230

...

Recommendation

Extend the IF statement so that the initialisation is triggered if any of the involved variables are active.

[smasson]

done in [15768]

[smasson]

In 15768:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found