New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#563 (hardcoded nlay_s) – NEMO

Opened 13 years ago

Closed 8 years ago

Last modified 14 months ago

#563 closed Bug (wontfix)

hardcoded nlay_s

Reported by: dupontf Owned by: vancop
Priority: low Milestone:
Component: LIM3 Version: v3.4
Severity: Keywords: LIM* v3.4
Cc:

Description

Hi all,

I found a couple of places where nlay_s is replaced by a hardcoded value of one.

-limitd_me: the esnon_init, esrdg and esrft fields have no provision for varying nlay_s and a jk loop should be added accordingly.

-line 942-944 of limitd_th.F90. A jk loop should be added.

-line 738 of limupdate.F90?

-lines 739-741 have no provision for nlay_s different from one:

My suggested correction for this particular one:

DO numeq = nlay_s, 2, -1

layer = numeq - 1
t_s_b(ji,layer) = (zindtbis(numeq) - ztrid(numeq,3)* &

t_s_b(ji,layer+1))/zdiagbis(numeq)

END DO

But I would prefer that somebody more knowledgeable than I am double-checks this.

Fred.

Commit History (0)

(No commits)

Change History (7)

comment:1 Changed 13 years ago by dupontf

  • Component changed from OPA to LIM3

comment:2 Changed 10 years ago by vichi

  • Owner changed from NEMO team to vancop
  • Version changed from v3.2 to v3.4

comment:3 Changed 8 years ago by vancop

  • Resolution set to wontfix
  • Status changed from new to closed

The number of layers in the snow must be one at present. We may change it in the future.

comment:4 Changed 5 years ago by nemo

  • Keywords LIM* added

comment:5 Changed 5 years ago by nemo

  • Keywords release-3.4* added

comment:6 Changed 5 years ago by nemo

  • Keywords release-3.4* removed

comment:7 Changed 14 months ago by nemo

  • Keywords v3.4 added
Note: See TracTickets for help on using tickets.