BUG in wind stress over ice when NEC computer + CORE bulk formulae

[gm]

This critical bug only concerns NEC users having sea-ice defined (key_lim3 or key_lim3)

sbcblk_core.F90 : the following lines can be found in the blk_ice_core routine:

      ! ----------------------------------------------------------------------------- !
      !    Wind components and module relative to the moving ocean ( U10m - U_ice )   !
      ! ----------------------------------------------------------------------------- !
      SELECT CASE( cd_grid )
      CASE( 'I' )                  ! B-grid ice dynamics :   I-point (i.e. F-point with sea-ice indexation)
         !                           and scalar wind at T-point ( = | U10m - U_ice | ) (masked)
#if defined key_vectopt_loop
!CDIR COLLAPSE
#endif
!CDIR NOVERRCHK
         DO jj = 2, jpjm1
            DO ji = 2, jpim1   ! B grid : NO vector opt
               ! ... scalar wind at I-point (fld being at T-point)
               zwndi_f = 0.25 * (  sf(jp_wndi)%fnow(ji-1,jj  ,1) + sf(jp_wndi)%fnow(ji  ,jj  ,1)   &
                  &              + sf(jp_wndi)%fnow(ji-1,jj-1,1) + sf(jp_wndi)%fnow(ji  ,jj-1,1)  ) - pui(ji,jj)

Due to an out-of-bound problem (see ticket #380) the loop over ji index is always from 2 to jpim1.

When key_vectopt_loop is defined (always the case on vector computer such as NEC), the NEC compiler instruction !CDIR COLLAPSE is active.

Therefore the two DO-loops on jj and ji are collapsed. The computation is then done from jpj +2 to (jpj-1)*(jpi-2) whereas it should be done until [ (jpj-1)*jpi -1 ].

In ORCA2-LIM (same for ORCA05, 025...), this means that the lines jpj-1 and half the line jpj-2 will not be computed ! The stress at the surface of the ice will be zero there, resulting in a strange ice thinkness pattern at the north fold....

The solution is simply to remove the following three lines :

#if defined key_vectopt_loop
!CDIR COLLAPSE
#endif

This problem concerns v3.2 and v3.3beta.

In v3.1, the out-of-bound problem was there (ticket #380) and so not this huge zeroing of ice stress.

Gurvan.

PS: many thanks to Frederic Dupont who was the first to point out the ice anomalies near the north fold in the reference ORCA2-LIM simulation performed with CORE2 forcing

[gm]

Done in v3.3beta see changeset:2412 together with stylistic only modifications in sbcblk_clio.F90

[cetlod]

Done in v3.2 consolided version, see changeset:2419