Opened 13 years ago
Closed 13 years ago
#832 closed Bug (fixed)
Missing brackets in volume filter correction calculation when computing before scale factor at u/v points (key_vvl)
Reported by: | acc | Owned by: | acc |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OCE | Version: | v3.3 |
Severity: | Keywords: | ||
Cc: |
Description
Missing brackets when computing the inverse of surface area at u/v points (zs_u_1 and zs_v_1) introduce large errors in the computation of the before scale factors at u/v points (fse3u_b and fse3v_b). The same error occurs during initialisation in domvvl.F90. In both cases:
zs_u_1(:,:) = 0.5 / e1u(:,:) * e2u(:,:)
zs_v_1(:,:) = 0.5 / e1v(:,:) * e2v(:,:)
should be:
zs_u_1(:,:) = 0.5 / ( e1u(:,:) * e2u(:,:) )
zs_v_1(:,:) = 0.5 / ( e1v(:,:) * e2v(:,:) )
This is likely to be a major contributor to the problems reported in #812 which were fixed by avoiding the use on fse3u/v_b in dynspg_ts.F90. That problem should be reinvestigated in the light of this fix.
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
2779 | acc | 2011-06-07T19:09:43+02:00 | #832. Corrections to before scale factor calculations (fse3u_b and fse3v_b). |
Change History (1)
comment:1 Changed 13 years ago by acc
- Resolution set to fixed
- Status changed from new to closed
Fixes to dynnxt.F90 and domvvl.F90 added at changeset 2779