Opened 11 years ago
Closed 10 years ago
#960 closed Bug (fixed)
Bug in trdmld & trdmld_trc - time step control
| Reported by: | marti | Owned by: | gm |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | OCE | Version: | trunk |
| Severity: | Keywords: | ||
| Cc: |
Description
Check of time stepping in trdmld.F90 is wrong.
Line 763 in trunk :
IF( ( lk_trdmld ) .AND. ( MOD( nitend, nn_trd ) /= 0 ) ) THEN
Works only if NIT000 = 1
Should be :
IF( ( lk_trdmld ) .AND. ( MOD( nitend-nit000+1, nn_trd ) /= 0 ) ) THEN
In trdmld_trc.F90, line 1258 should be corrected the same way, using nittrc000 :
IF( ( lk_trdmld_trc ) .AND. ( MOD( nitend-nittrc000+1, ntrd_trc ) /= 0 ) ) THEN
Olivier
Commit History (3)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 3794 | gm | 2013-02-10T20:13:47+01:00 | CMIP_IPSL branch: #960 : correct bug in trdmld & trdmld_trc (time step control) |
| 3793 | gm | 2013-02-10T20:11:06+01:00 | dev_v3_4_STABLE_2012: #960 : correct bug in trdmld & trdmld_trc (time step control) + KPP/TRC compatibility (zdfkpp.F90) |
| 3792 | gm | 2013-02-10T20:06:22+01:00 | dev_MERGE_2012: #960 : correct bug in trdmld & trdmld_trc (time step control) + KPP/TRC compatibility (zdfkpp.F90) |
Change History (2)
comment:1 Changed 10 years ago by clevy
- Owner changed from NEMO team to gm
comment:2 Changed 10 years ago by gm
- Resolution set to fixed
- Status changed from new to closed
Many thanks Olivier
The check has been changed in the future v3.4.1 (stable) and v3.5 alpha as well as on the CMIP5_IPSL branch
see Changeset 3793 for branches/2012/dev_v3_4_STABLE_2012 (future v3.4.1)
see Changeset 3792 for v3.5 alpha
see Changeset 3794 for branches/CMIP5_IPSL
CAUTION: In the v3.4.1 and v3.5alpha changesets above, I have also introduced some changes in zdfkpp.F90 that are not related to the problem describe in this ticket, but related to compilation errors when using KPP with passive tracers (issue found by defining key_esopa on the ORCA2_LIM_PISCES configuration)
Gurvan