Changes between Version 11 and Version 12 of 2011WP/2011Stream2/DynamicMemory

Timestamp:

2011-01-19T14:33:39+01:00 (14 years ago)

Author:

trackstand

Comment:

--

2011WP/2011Stream2/DynamicMemory

@@ -507 +507 @@
 I can appreciate that an almost global change like this will be difficult for users who have locally modified versions. Ideally the source-code revision-control system would facilitate applying the changes to a locally-modified version/branch - one that isn't in the official repository. Unfortunately I don't think subversion has this functionality (although I'd be very pleased to learn otherwise). Certainly I'll do my best to avoid unnecessary cosmetic changes. However, while I can imagine that scripting the change of module arrays from static to dynamic might be possible, I don't think the same can be said of the work-space arrays and they account for a lot of the code changes.
 
+In fact, I'm discovering that some routines have an awful lot of workspace arrays.
+e.g.:
+
+{{{
+   SUBROUTINE dyn_spg_ts( kt )
+      !!----------------------------------------------------------------------
+      !!                  ***  routine dyn_spg_ts  ***
+      !!
+      !! ** Purpose :   Compute the now trend due to the surface pressure
+...
+      !! References : Griffies et al., (2003): A technical guide to MOM4. NOAA/GFDL
+      !!---------------------------------------------------------------------
+      INTEGER, INTENT(in)  ::   kt   ! ocean time-step index
+      !!
+      INTEGER  ::   ji, jj, jk, jn   ! dummy loop indices
+      INTEGER  ::   icycle           ! temporary scalar
+
+      REAL(wp) ::   zraur, zcoef, z2dt_e, z2dt_b     ! temporary scalars
+...
+      !!
+      REAL(wp), DIMENSION(jpi,jpj) ::   zhdiv, zsshb_e
+      !!
+      REAL(wp), DIMENSION(jpi,jpj) ::   zbfru  , zbfrv     ! 2D workspace
+      !!
+      REAL(wp), DIMENSION(jpi,jpj) ::   zsshun_e, zsshvn_e   ! 2D workspace
+      !!
+      REAL(wp), DIMENSION(jpi,jpj) ::   zcu, zwx, zua, zun   ! 2D workspace
+      REAL(wp), DIMENSION(jpi,jpj) ::   zcv, zwy, zva, zvn   !  -      -
+      REAL(wp), DIMENSION(jpi,jpj) ::   zun_e, zub_e, zu_sum      ! 2D workspace
+      REAL(wp), DIMENSION(jpi,jpj) ::   zvn_e, zvb_e, zv_sum      !  -      -
+      REAL(wp), DIMENSION(jpi,jpj) ::   zssh_sum                  !  -      -
+      !!----------------------------------------------------------------------
+
+      IF( kt == nit000 ) THEN             !* initialisation
+}}
+I make that 21 2D workspace arrays! Should the global workspace module contain that
+many or should we make some of these into module-wide arrays?
+
 ----