New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2019WP/ENHANCE-02_PierreMathiot_ISF – NEMO
wiki:2019WP/ENHANCE-02_PierreMathiot_ISF

ENHANCE-02_PierreMathiot_ISF

The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.

Help

The action has to be detailed briefly in the 'Summary' for later inclusion in other pages. To do so, edit 'Summary' section as a common wiki page and set links for the development ticket and branch.

Out of this, the rest of the page ('Abstract'|'Preview'|'Tests'|'Review') can be edited on-line inside the form fields considering the following color code given hereafter: PI(S), Previewer(s) and Reviewer(s).
Record your modifications for the section you have edited by clicking on the corresponding button at the end of the section with 'Save ...' button. Just above, the log record will be updated.

The informations inside the form fields and this wiki page itself are stored in 2 separate databases. As a consequence, there is absolutely no risk to make any modification in the page itself as long as you don't rename the page or modify the source code of {{{#!TracForm ... }}} processors.

Summary

Action ENHANCE-02_PierreMathiot_ISF
PI(S) Pierre Mathiot

Digest

Developments of ice shelf code:

  • Coupling with ice sheet model (method currently in test by UKESM based on NEMO 3.6):
    • new method to correct the dynamics part when restart after coupling with ice sheet model (more stable)
    • new method to correct the thermodynamic after coupling with an ice sheet model (decrease the spin up time of the new cells)
    • fixing issue with conservation routine when coupling to an active ice shelf model
  • Code cleaning:
    • code cleaning (move all ISF routines/subroutine in an ISF directory + general cleaning)
    • new geometry computation (old computation removed and rewriten from scratch based on discussion with BAS/Reading/IGE)
    • Check if all lbc_lnk are useful in ISF code. It is likely only lbc_lnk on utbl and vtbl are needed.
  • New simple capability:
    • split explicit cavity and parametrisation to run with some cavity (the giant for example) and a parametrisation for the small one and add it in WED025.
  • Configurations:
    • Add regional WED025 configuration (bdy + tide + sea ice + ice shelf) (Chris Bull configuration from BAS). Could replace SPITZ12.
    • Upgrade ISOMIP test case to ISOMIP+ with test of the coupling capability.
  • Update documentation accordingly
    • A dedicated ISF section as there is ISF directory

04/01/2020: to do but not done during 2019:

  • Move maybe iceload as input file or find a more robust way to compute it.
  • Remove all call to risfdep in NEMO as risfdep is equal to gdepw_n(ji,jj,mikt(ji,jj))
  • Is gde3w_n still useful as gdept = sum(e3w) by definition ?
  • Check and reply ISF Gurvan question in the code
  • Review the duplicated routine _isf and take action if simplification can be done
  • vertical gradient at the ice shelf based should be 0 (rm special case at the top interface in vertadv) (GM)
  • computation of ice load could be simplify (GM)

Wiki : https://forge.ipsl.jussieu.fr/nemo/wiki/2019WP/ENHANCE-02_PierreMathiot_ISF

Dependencies
Target
Trac Ticket #2142
SVN branch branches/$YEAR/dev_r{REV}_{SCOPE}-{NUM}_{PIS}-{KEYWORDS}
Previewer(s) Nicolas Jourdain
Reviewer(s) Nicolas Jourdain
Link ExtractUrl(.)?

Abstract

This section should be completed before starting to develop the code, in order to find agreement on the method beforehand.

Error: Failed to load processor TracForm
No macro or processor named 'TracForm' found

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.

Preview

Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.
For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.

Error: Failed to load processor TracForm
No macro or processor named 'TracForm' found

Once all "YES" have been reached, the PI can start the development into his development branch.

Tests

Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section.

Error: Failed to load processor TracForm
No macro or processor named 'TracForm' found

Review

A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).

Error: Failed to load processor TracForm
No macro or processor named 'TracForm' found

Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.

Last modified 3 years ago Last modified on 2020-01-06T11:20:59+01:00