Changes between Version 4 and Version 5 of 2019WP/ENHANCE-09_Jerome_freesurface
- Timestamp:
- 2017-10-25T11:13:53+02:00 (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
2019WP/ENHANCE-09_Jerome_freesurface
v4 v5 1 = '''''ENHANCE-4_Jerome_freesurface''''' = 2 The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected. 1 = '''''ENHANCE-4_Jerome_freesurface''''' 3 2 4 == Help ==5 The action has to be detailed briefly in the 'Summary' section for later inclusion in other pages.\\ Edit the 'Summary' section as with an ordinary wiki page.6 3 7 * ''Italic formatting'' shows the default values or help.8 * Set specific TracLinks (development ticket and branch).9 4 10 Out of this, the rest of the page can be edited on-line inside the form fields considering the following color code given hereafter. 5 == Summary #summary 11 6 12 {{{#!th 7 || '''Action''' || ENHANCE-4_Jerome_freesurface || 8 || '''PI(S)''' || Jérôme Chanut || 9 {{{#!td 10 '''Digest''' 11 }}} 12 {{{#!td 13 Improve split-explicit free surface: 14 * Tracer conservation issues (all time splitting options do not ensure global and local tracer conservation) 15 * Missing correction terms in the barotropic equations relative to internal pressure gradients. This would reduce mode splitting error, hence improve stability 16 * Work on the stability of barotropic time stepping (based on INRIA's work) to possibly remove time filtering of barotropic variables.\\ 17 This would limit the temporal dissipation and greatly ease online coupling of nested domains at barotropic level (with AGRIF). 18 }}} 19 |- 20 || '''Dependencies''' || ''New time stepping implementation'' || 21 || '''Target''' || ''started'' || 22 || '''Trac Ticket''' || #1959 || 23 || '''SVN branch''' || [source:/branches/2017/dev_r8624_ENHANCE4_FREESURFACE/] || 24 || '''Previewer(s)''' || ''Gurvan Madec'' || 25 || '''Reviewer(s)''' || ''TBD'' || 26 || '''Status''' || In progress: an implementation exists || 27 || '''Link''' || [[ExtractUrl(.)]] || 13 28 14 Role / Color code 15 29 {{{#!comment 30 DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 31 }}} 32 == == 33 {{{#!comment 34 DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 16 35 }}} 17 36 18 || [[span(PI(S), style=background-color:lightgrey)]] || [[span(Previewer(s), style=background-color:lightblue)]] || [[span(Reviewer(s), style=background-color:lightgreen)]] || 19 20 Record your modifications for the section you have edited by clicking on the corresponding button at the end of the section with 'Save ...' button. Just above, the log record will be updated. 21 22 The informations inside the form fields and this wiki page itself are stored in 2 separate databases.\\ As a consequence, there is absolutely no risk to make any modification in the page itself as long as you don't rename the page or modify the source code of `{{{#!TracForm ... }}}` processors. 23 24 == Summary == #summary 25 || '''Action''' || ENHANCE-4_Jerome_freesurface || 26 || '''PI(S)''' || Jérôme Chanut || 27 28 {{{#!td '''Digest''' }}} {{{#!td Improve split-explicit free surface: 29 30 * Tracer conservation issues (all time splitting options do not ensure global and local tracer conservation) 31 * Missing correction terms in the barotropic equations relative to internal pressure gradients. This would reduce mode splitting error, hence improve stability 32 * Work on the stability of barotropic time stepping (based on INRIA's work) to possibly remove time filtering of barotropic variables.\\ This would limit the temporal dissipation and greatly ease online coupling of nested domains at barotropic level (with AGRIF). 33 34 }}} |- 35 36 || '''Dependencies''' || ''Depends on ...'' || 37 || '''Target''' || ''started; need to be scientifically reviewed ; can be ready for merge 2017.'' || 38 || '''Trac Ticket''' || !#1959 || 39 || '''SVN branch''' || [source:/branches/$YEAR/dev_r{REV}_{WGorINSTITUTE}-{NUM}_{PIS}-{KEYWORDS} /branches/2017/dev_r8624]_ENHANCE4_FREESURFACE || 40 || '''Previewer(s)''' || ''Gurvan Madec'' || 41 || '''Reviewer(s)''' || ''-'' || 42 || '''Status''' || In progress: an implementation exist || 43 || '''Link''' || [[ExtractUrl(.)]] || 44 45 {{{#!comment DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES }}} 46 47 == == 48 {{{#!comment DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES }}} 49 50 {{{#!Fold title=Abstract tag=h2 [=#abstract] 37 {{{#!Fold title=Abstract tag=h2 38 [=#abstract] 51 39 52 40 This section should be completed before starting to develop the code, in order to find agreement on the method beforehand. 53 41 54 {{{#!TracForm #!subcontext abstract #!submit_label 'Save Abstract' #!keep_history yes 42 {{{#!TracForm 43 #!subcontext abstract 44 #!submit_label 'Save Abstract' 45 #!keep_history yes 55 46 56 === Description === 57 [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 47 === Description 58 48 59 === Implementation === 60 [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 49 [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 61 50 62 === Reference manual and web pages updates === 63 [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 51 === Implementation 52 53 [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 54 55 === Reference manual and web pages updates 56 57 [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 64 58 65 59 '''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' … … 71 65 }}} 72 66 73 {{{#!Fold title=Preview tag=h2 [=#preview] 67 {{{#!Fold title=Preview tag=h2 68 [=#preview] 74 69 75 70 Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.[[BR]]For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions. 76 71 77 {{{#!TracForm #!subcontext preview_ #!submit_label 'Save Preview' 72 {{{#!TracForm 73 #!subcontext preview_ 74 #!submit_label 'Save Preview' 78 75 79 76 || Questions || Answer || Comment || … … 92 89 }}} 93 90 94 {{{#!Fold title=Tests tag=h2 [=#tests] 91 {{{#!Fold title=Tests tag=h2 92 [=#tests] 95 93 96 94 Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section. 97 95 98 {{{#!TracForm #!subcontext tests #!submit_label 'Save Tests' 96 {{{#!TracForm 97 #!subcontext tests 98 #!submit_label 'Save Tests' 99 99 100 100 || Questions || Answer || Comment || … … 117 117 }}} 118 118 119 {{{#!Fold title=Review tag=h2 [=#review] 119 {{{#!Fold title=Review tag=h2 120 [=#review] 120 121 121 122 A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November). 122 123 123 {{{#!TracForm #!subcontext review #!submit_label 'Save Review' 124 {{{#!TracForm 125 #!subcontext review 126 #!submit_label 'Save Review' 124 127 125 === Code changes and documentation === 128 === Code changes and documentation 129 126 130 || Question || Answer || Comment || 127 131 || Is the proposed methodology now implemented? || [tf.select:3.11 -id=revform '' Yes No NR] || [tf.textarea:3.11c -id=revform 'Add a comment?' 50 10] || … … 135 139 || ... ... ... || [tf.select:3.XX -id=revform '' Yes No NR] || [tf.textarea:3.XXc -id=revform 'Add a comment?' 50 10] || 136 140 137 ==== Review Summary ==== 141 ==== Review Summary 142 138 143 Is the review fully successful? [tf.select:status -id=revform '' Yes No] 139 144
