Changes between Version 7 and Version 8 of 2020WP/KERNEL-06_techene_better_e3_management

Timestamp:

2020-03-19T15:12:46+01:00 (3 years ago)

Author:

techene

Comment:

--

2020WP/KERNEL-06_techene_better_e3_management

@@ -38 +38 @@
 }}}
 
-Step 1 : Check the error for e3t, e3w between the current way to compute e3 at T-, W-point and the proposed way to compute e3 at T-, W-point.
+Eventually, all the dom_vvl_interpol call are removed, each time e3 is called we use a substitute to replace e3 by e3_0 (1 + ssh / h_0). For backward compatibility a cpp key manages the use of the new version vs. the old version. We will duplicate modules such as step and domvvl into stepLF and domQE (QE stands for Quasi Eulerian) and create a subtitute module. 
 
-Because this change is likely to induce changes in the code we need to insure and because we need backward compatibility, we will duplicate the modules that will be modified and implement changes gradually.
-
-Step 2 : First we change only the core routine in domvvl which should be changed into domQE.
-- add new variables, duplicate step into steplf and domvvl into domQE
-- change interpolation routines into scaling routines in domQE
-Step 3 : Then we change the Asselin filtering routine indeed because water forcing are applied locally.
-- change Asselin routines (maybe not required since e3 scale with vertical with JC modif)
-Step 4 : Finally we remove the interpol routine in the whole code
-- remove interpolating routine in all the code (AGRIF, OFF,...) 
-- use a SUBSTITUTE when there are e3 CALL
-- make some changes in step and domQE to have the whole thing consistent
-
-
+List the Fortran modules and subroutines to be edited.
+- src/ICE/iceistate.F90
+- src/OCE/DIA/diamlr.F90
+- src/OCE/DOM/dom_oce.F90
+- src/OCE/DOM/domain.F90
+- src/OCE/DOM/dommsk.F90
+- src/OCE/SBC/sbcblk.F90
+- src/OCE/SBC/sbcice_cice.F90
+List the Fortran modules and subroutines to be duplicated/edited.
+- src/OCE/DOM/domvvl.F90
+- src/OCE/step.F90
+List the Fortran modules and subroutines to be XXX.
+- src/OCE/DYN/dynatf.F90
+- src/OCE/TRA/traatf.F90
+List the Fortran modules and subroutines to be created.
+substitute.F90
 
 ''...''
@@ -71 +74 @@
 }}}
 
-
+Step 1 : Check the error for e3t, e3w between the current way to compute e3 at T-, W-point and the proposed way to compute e3 at T-, W-point.
+- prints added with no change in the results
+Step 2 : First we change only the core routine in domvvl which should be changed into domQE.
+- add new variables, duplicate step into steplf and domvvl into domQE
+- change interpolation routines into scaling routines in domQE
+Step 3 : Then we change the Asselin filtering routine indeed because water forcing are applied locally.
+- change Asselin routines (maybe not required since e3 scale with vertical with JC modif)
+Step 4 : Finally we remove the interpol routine in the whole code
+- remove interpolating routine in all the code (AGRIF, OFF,...) 
+- use a SUBSTITUTE when there are e3 CALL
+- make some changes in step and domQE to have the whole thing consistent
 
 ''...''
@@ -85 +98 @@
 Reference set up : For that we produce a reference data set with the trunk -r 12377 using the GYRE_PISCES configuration where top cpp_key has been removed. We run it on 120 time steps. The drag coefficient is zero. We XIOS output an averaged field every 5 days. 
 
+Step 1 : We print MAXVAL of error between both way to compute the vertical scale factors at each time step, note that we cancelled forcing (in the r12377 revision it should not change anything since water forcings such as run off and emp scale with the vertical).
+
+error between proposed and former way to compute vertical scale factors at time kt = 1, 120, 85
+e3t (1)
+0.0000000000000000
+3999.6591076268369
+4.54747350886E-013
+e3t (2)
+5.68434188608E-014
+5.11590769747E-013
+4.54747350886E-013
+e3w
+'''4.64477238892E-007
+6.13657050507E-006
+5.27333801869E-006'''
+gde3w
+1.81898940354E-012
+2.72848410531E-012
+2.72848410531E-012
+
+QUESTION : Why do we have such an error on the e3w scale factors ? It is not consistent with machine accuracy error. It seems to be related to the e3w_0 computation. How do we compute e3w_0 ? 
+