Version 16 (modified by rlod, 5 months ago) (diff)

Name and subject of the action

Last edition: 11/30/20 18:04:30 by aumont

The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.

  1. Summary
  2. Preview
  3. Tests
  4. Review

Summary

Action Implementation of iceberg and ice shelf Fe source in PISCES
PI(S) Renaud Person
Digest see person et al. (2019), doi: 10.5194/bg-16-3583-2019
Dependencies coupling with feshwater fluxes from ice shelf and iceberg
Branch source:/NEMO/branches/2020/dev_r{REV}_{ACTION_NAME}
Previewer(s) O.Aumont, C. Éthe
Reviewer(s) O.Aumont, C. Éthe
Ticket #2443

Description

Based on the development done with NEMO 3.6 of the representation of the missing external source of Fe from iceberg and ice shelf in the PISCES model

Implementation

Representation of the external source of biogeochemical tracers from iceberg and ice shelf. For instance, for dissoved Fe, a sediment content associated to a solubility fraction of sediment Fe is added to the freshwater fluxes of iceberg and ice shelf. For iceberg, a homogeneous distribution of the biogeochemical tracers until 120 m of depth is applied. For ice shelf, the biogeochemical tracer content is distributed homogeneously following the representation of the isf freshwater flux of Mathiot et al. (2017) whether the under ice shelf cavities are open or not.

File dependency: feshwater fluxes from ice shelf and iceberg:

  • runoff-icb_DaiTrenberth_Depoorter_eORCA1_JD.nc
  • runoff-icb_DaiTrenberth_Depoorter_eORCA025_JD.nc

This file dependency didn’t exist for ORCA2 configuration as the grid is not extended in Antarctica. As a consequence, there is no representation of ice shelf cavities which are needed to model the distribution of freshwater flux under ice shelves with the parameterizations of Mathiot et al. (2017). Thus, this module can not be activated in ORCA2, the external source of BGC tracers from the Antarctic Ice Sheet is consequently disabled in this configuration.

  • Activation in TOP:

Creation of the trcais routine controllable in TOP module, which allows to adjust the concentration of Fe, for now, and of other biogeochemical tracers (potentially later) associated with iceberg and ice shelf freshwater fluxes through a loop over all the biogeochemical tracers. The AIS tracers source can be activated with a boolean in the namelist_top:

ln_trcais = .false. ! Antarctic Ice Sheet nutrient supply

!———————————————————————————————————-

&namtrc_ais ! Representation of Antarctic Ice Sheet tracers supply

!———————————————————————————————————-

rn_trafac(14) = 4.476e-07 ! ( 0.5e-3 / 55.85 * 0.05 )

!

nn_ais_tr = 1 ! tracer concentration in iceberg and ice shelf

  • 0 is for null concentrations
  • 1 for prescribed concentrations

rn_icbdep = 120. ! Mean underwater depth of iceberg (m)

Warning: the isf source has to be activated in the namelist_cfg:

ln_isf = .true.

then chose one of the two options for isf melt:

ln_isfcav_mlt = .false. or ln_isfpar_mlt = .true.

and activate runoff from icebergs

ln_rnf_icb = .true. ! freshwater flux from icebergs

created routine:

  • trcais.F90

List of modified routines:

  • nemogcm.F90
  • sbcrnf.F90
  • trc.F90
  • trcini.F90
  • trcnam.F90
  • trctrp.F90

Documentation updates

Using previous parts, define the main changes to be done in the NEMO literature (manuals, guide, web pages, …).

Preview

Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s).
Then an iterative process should take place between PI and previewer(s) in order to find a consensus

Possible bottlenecks:

  • the methodology
  • the flowchart and list of routines to be changed
  • the new list of variables wrt coding rules
  • the summary of updates in literature

Once an agreement has been reached, preview is ended and the PI can start the development into his branch.

Tests

Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.

This part should contain the detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test

Regular checks:

  • Can this change be shown to produce expected impact (option activated)?
  • Can this change be shown to have a null impact (option not activated)?
  • Results of the required bit comparability tests been run: are there no differences when activating the development?
  • If some differences appear, is reason for the change valid/understood?
  • If some differences appear, is the impact as expected on model configurations?
  • Is this change expected to preserve all diagnostics?
  • If no, is reason for the change valid/understood?
  • Are there significant changes in run time/memory?

Review

A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).

Assessments:

  • Is the proposed methodology now implemented?
  • Are the code changes in agreement with the flowchart defined at preview step?
  • Are the code changes in agreement with list of routines and variables as proposed at preview step?
    If, not, are the discrepancies acceptable?
  • Is the in-line documentation accurate and sufficient?
  • Do the code changes comply with NEMO coding standards?
  • Is the development documented with sufficient details for others to understand the impact of the change?
  • Is the project literature (manual, guide, web, …) now updated or completed following the proposed summary in preview section?

Finding:

Is the review fully successful? If not, please indicate what is still missing


Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.

Attachments (1)

Download all attachments as: .zip