Version 5 (modified by cbricaud, 12 months ago) (diff)

Name and subject of the action

Last edition: 06/10/21 09:57:47 by cbricaud

The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.

  1. Summary
  2. Preview
  3. Tests
  4. Review


PI(S) Bricaud Clément
Digest improve GLS
Dependencies no
Branch source:/NEMO/branches/2021/dev_r14318_MOI-02_MOI-GLS-ICE/
Previewer(s) Names
Reviewer(s) Names
Ticket #2604


2 improvevments for GLS:

  • scaling of mixing under sea-ice ( do as it is in TKE)
  • add limit condition under ice shelves


improve GLS scaling of mixing under sea-ice ( do as it is in TKE)

4 options of scaling under sea oce are available for TKE;

0: no scaling

1: scale with constant sea-ice thickness

2: scaling with mean sea-ice thickness

3: scaling with max sea-ice thicknesss

only one is available for GLS: scaling with constant roughness, equivalent to CASE 1 in TKE.

  • Options 0,1,3 should be addded in GLS
  • As for TKE, nn_mxlice wil be added in namelist

add limit condition under ice shelves

Surface boundary condition should be modified under the ice-shelves seas:

  • for TKE and psi
  • for Neumann and Dirichlet conditions

Documentation updates

Using previous parts, define the main changes to be done in the NEMO literature (manuals, guide, web pages, …).


Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s).
Then an iterative process should take place between PI and previewer(s) in order to find a consensus

Possible bottlenecks:

  • the methodology
  • the flowchart and list of routines to be changed
  • the new list of variables wrt coding rules
  • the summary of updates in literature

Once an agreement has been reached, preview is ended and the PI can start the development into his branch.


The MXLICE_ORCA2.pdf​ in #2604 show some the effects of the different scaling with GLS on the reference ORCA2_ICE configuration.

Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.

This part should contain the detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test

Regular checks:

  • Can this change be shown to produce expected impact (option activated)?
  • Can this change be shown to have a null impact (option not activated)?
  • Results of the required bit comparability tests been run: are there no differences when activating the development?
  • If some differences appear, is reason for the change valid/understood?
  • If some differences appear, is the impact as expected on model configurations?
  • Is this change expected to preserve all diagnostics?
  • If no, is reason for the change valid/understood?
  • Are there significant changes in run time/memory?


A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).


  • Is the proposed methodology now implemented?
  • Are the code changes in agreement with the flowchart defined at preview step?
  • Are the code changes in agreement with list of routines and variables as proposed at preview step?
    If, not, are the discrepancies acceptable?
  • Is the in-line documentation accurate and sufficient?
  • Do the code changes comply with NEMO coding standards?
  • Is the development documented with sufficient details for others to understand the impact of the change?
  • Is the project literature (manual, guide, web, …) now updated or completed following the proposed summary in preview section?


Is the review fully successful? If not, please indicate what is still missing

Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.