New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/1085/Review – NEMO
wiki:ticket/1085/Review

Version 2 (modified by hadcv, 11 years ago) (diff)

--

Last edited Timestamp?

For completion by the Sci/Tech/Code? reviewer

Reviewer: [ Enter your name here ]

Ticket Details, Documentation and Code changes

Do you understand the area of code being altered and the reasoning why it is being altered?YES/NO
Do the proposed code changes correspond with the stated reason for the change?YES/NO
Is the in-line documentation accurate and sufficient?YES/NO
Do the code changes comply with NEMO coding standards?YES/NO
Is the Ticket documented with sufficient detail for others to understand the impact of the change?YES/NO
Does any corresponding external documentation require updating?YES/NO
If yes, which docs and have the updates been drafted?YES/NO
Are namelist changes required for this change?YES
If yes, have they been done?YES
Has a completed Ticket Summary template been appended to the ticket to aid code reviewsYES
Does this summary correspond with your understanding of the full ticket?YES/NO

Ticket, Documentation and Code comments

Add specific Ticket, Documentation and code comments here

Testing

Has the NVTK and other jobs been tested with this change?YES/NO
Have the required bit comparability tests been run?YES/NO
Can this change be shown to have a null impact? (if option not selected)YES/NO
If no, is reason for the change valid/understood?YES/NO/NA
If no, ensure that the ticket details the impact this change will have on model configurations .YES/NO/NA
Is this change expected to preserve all diagnostics?YES
If no, is reason for the change valid/understood?N/A
Are there significant changes in run time/memory?NO

Testing Comments

  • More testing information can be found in the changeset documentation at wiki:ticket/1085

Code Review

Do the code changes comply with NEMO coding standards?YES/NO
Are code changes consistent with the design of NEMO?YES/NO
Is the code free of unwanted TABs?YES/NO
Has the code been wholly (100%) produced by NEMO developers working on NEMO?YES

Add specific code comments or suggested alterations here.

Review Summary

Add summary here

Approval for the trunk

YES/NO

The code reviewer may approve the change for the NEMO trunk when:

  1. their requests/comments have been addressed satisfactorily.
  2. the above check-list has been completed.

or the code reviewer may choose to reject & assign the change back to the code author.