New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/1148 – NEMO
wiki:ticket/1148

Version 3 (modified by djlea, 11 years ago) (diff)

--

Last edited Timestamp?


Author : Andy Ryan (c/o Dan Lea)

ticket : #1148

Branch : dev_r3987_UKMO4_OBS


Description


Testing

Testing could consider (where appropriate) other configurations in addition to NVTK].

SETTE TestedYES
Other model configurationsYES: Gyre, ORCA2 ...
Processor configurations tested[ 2x2, 1x4, 2x8, 4x4 ]
If adding new functionality please confirm that the
New code doesn't change results when it is switched off
and ''works'' when switched on
YES to both, solver.stat and ocean.output identical to trunk

(Answering UNSURE is likely to generate further questions from reviewers.)

'Please add further summary details here'

  • Processor configurations tested
  • etc----

Bit Comparability

Does this change preserve answers in your tested standard configurations (to the last bit) ?YES
Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)YES
Is this change expected to preserve answers in all possible model configurations?YES
Is this change expected to preserve all diagnostics?
,,''Preserving answers in model runs does not necessarily imply preserved diagnostics. ''
YES

If you answered '''NO''' to any of the above, please provide further details:

  • Which routine(s) are causing the difference?
  • Why the changes are not protected by a logical switch or new section-version
  • What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not.
  • What do you expect to see occur in the test harness jobs?
  • Which diagnostics have you altered and why have they changed?Please add details here........

System Changes

Does your change alter namelists?YES
Does your change require a change in compiler options?NO

We added a ln_nightav namelist option to fix a bug in a previous commit whereby SST data was assuming night time average data in all cases. There is now a namelist variable in the OBS namelist to allow this to be turned on where night time average data is provided. Note without this change the offline observation operator code does not work since it currently has no concept of day time or night time as it does not run the ocean model.


Resources

None


IPR issues

Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?YES

If No:

  • Identify the collaboration agreement details
  • Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution? etc).Add further details here if required..........

Attachments (7)

Download all attachments as: .zip