Changes between Version 7 and Version 8 of ticket/1296


Ignore:
Timestamp:
2014-08-13T17:35:43+02:00 (6 years ago)
Author:
timgraham
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1296

    v7 v8  
    1717'''Requirements:''' 
    1818 
    19 1) Damping climatologies can be different to climatological start files - use separate version of dia_tsd_read or implement new version?[[BR]]2) No grid dependence - controlled by mask file only[[BR]]3) Region entirely specified by mask file (both horizontal and vertical)[[BR]]4) Mask file can be used for varying coefficient (use values between 0 and 1) - i.e. 0 for no relxation or 1 for relaxation at the time scale specified in namelist[[BR]]5) Should work with VVL[[BR]]6) Make sure only one of tra_dmp or tra_rlx is used at one time.[[BR]]7) Fortran (and possibly python) scripts will be provided to generate the input mask files 
     19After discussion with Gurvan Madec, reviewer and systems team this task has been changed to modify the existing tra_dmp module rather than replacing it with tra_rlx. The modifications remove all grid dependent options from the NEMO code in line with the NEMO simplification plans.  
    2020 
    21 '''Namelist requirements:''[[BR]]'''''Although a new namelist section is needed this will eventually be a replacement for tra_dmp so still a simplification[[BR]]Needs:[[BR]]1) Mask file name[[BR]]2) Relaxation time scale (in seconds)[[BR]]3) Switch to damp in full column/only in mixed layer/only below mixed layer - this is current functionality that can't be reproduced using a maskfile.[[BR]]4) Mask variable name? 
     21All of these options (which were in the tra_dmp_init) routine have been moved to an offline tool called DMP_TOOLS. DMP_TOOLS creates a netcdf file containing a 3D field of the restoration coefficient to be used in the model run. This file is now read in by tra_dmp_init. Passive tracer damping (trcdmp.F90) has also been modified to read in a restoration coefficient from a file. 
    2222 
    23 '''Subroutines:''' 
     23The old behaviour with grid specific settings can be reproduced with the correct namelist options are supplied to the tool (these will be the default in the trunk) and if the tool is run on the same machine (and with the same compiler) as the model then it bit compares with the old version of the code. The netcdf file will be added to the tar files containing standard forcings but this may mean that it does not bit compare on other machines. 
    2424 
    25  * Copy of dia_tsd_read or modify dia_tsd_read to allow it to be used with different files (after initial conditions have been read) 
    26  * tra_rlx_init: [[BR]]    read the namelist, read the mask file (maybe separate subroutine), calculate restoration coefficient 
    27  * tra_rlx:[[BR]]    Calculate the trend at each point = rlx_mask * resto * (zts_dta - tsb)  (where zts_dta is the climatological value, resto is the restoration coefficient) and add to total trend[[BR]]    The climatology that we are relaxing to should be on the original model grid. Given the long time scales of the climatology compared to variations in SSH it seems reasonable not worry about the slight changes in vertical grid spacing. 
    28  * Link to trends diagnostics to output the trends? 
     25DMP_TOOLS takes a NEMO mesh_mask.nc file as input along with a namelist file. It also contains an empty custom module that can be edited by users to create their own restoration coefficient files (e.g. damping in a specific region only). 
    2926 
    3027---- 
     
    3229Testing could consider (where appropriate) other configurations in addition to NVTK]. 
    3330 
    34 || NVTK Tested || !'''YES/NO!''' || 
    35 || Other model configurations || !'''YES/NO!''' || 
    36 || Processor configurations tested || [ Enter processor configs tested here ] || 
    37 || If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || !'''YES/NO/NA!''' || 
     31|| SETTE Tested || !'''YES''' || 
     32|| Other model configurations || !'''ORCA2_LIM''' || 
     33|| Processor configurations tested || Standard processor configurations || 
     34|| If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || !'''YES''' || 
    3835 
    3936(Answering UNSURE is likely to generate further questions from reviewers.) 
    4037 
    4138'Please add further summary details here' 
    42  
    43  * Processor configurations tested 
    44  * etc---- 
     39Using the offline tool to create the damping coefficients for ORCA2_LIM configurations produces identical results to when the tool is compiled on the same machine as the model. 
    4540 
    4641=== Bit Comparability === 
    47 || Does this change preserve answers in your tested standard configurations (to the last bit) ? || !'''YES/NO !''' || 
    48 || Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || !'''YES/NO!''' || 
    49 || Is this change expected to preserve answers in all possible model configurations? || !'''YES/NO!''' || 
    50 || Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || !'''YES/NO!''' || 
     42|| Does this change preserve answers in your tested standard configurations (to the last bit) ? || !'''YES (if dmp_tools compiled/run on same machine as model''' || 
     43|| Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || !'''YES''' || 
     44|| Is this change expected to preserve answers in all possible model configurations? || !'''YES''' || 
     45|| Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || !'''YES''' || 
    5146 
    5247If you answered !'''NO!''' to any of the above, please provide further details: 
     
    6055---- 
    6156=== System Changes === 
    62 || Does your change alter namelists? || !'''YES/NO !''' || 
    63 || Does your change require a change in compiler options? || !'''YES/NO !''' || 
     57|| Does your change alter namelists? || !'''YES ''' || 
     58|| Does your change require a change in compiler options? || !'''NO !''' || 
    6459 
    65 If any of these apply, please document the changes required here....... 
     60nam_tradmp is changed to contain ln_tradmp, nn_zdmp and cn_resto only (cn_resto is the name of the netcdf file containing the restoration coefficient). All other options are now dealt with by dmp_tools. 
     61nam_trc_dmp is changed to contain only nn_zdmp_tr and cn_resto_tr only 
    6662 
    6763---- 
    6864=== Resources === 
    69 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 
     65Minimal changes to model runtime but may require the user to run the tool first. 
    7066 
    7167---- 
    7268=== IPR issues === 
    73 || Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO? || !'''YES/ NO !''' || 
     69|| Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO? || !'''YES''' || 
    7470 
    7571If No: