Changes between Version 2 and Version 3 of ticket/1851/General


Ignore:
Timestamp:
2017-02-22T10:18:10+01:00 (4 years ago)
Author:
frrh
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1851/General

    v2 v3  
    2222   This doesn't cause a failure because its an OOB read. I suspect it would cause a failure if it was an OOB write.  
    2323 
    24    *  We then get: 
     24   *  We then get a failure in trc_nam_medusa.F90: 
    2525{{{ 
    2626  lib-4213 : UNRECOVERABLE library error  
     
    3333}}} 
    3434 
     35   This error message doesn't lead us to any particular statement or line number which is a bit rubbish... the compiler must know but it doesn't bother to tell us.  
     36 
    3537   *  trcnam_medusa.F90 has a section where it's initialising variables from the  
    3638natbio namelist. However it initialises jdms_input twice thus... 
     
    3840      jdms_input  = 3 
    3941 
    40    why? 
     42   Why? 
     43 
    4144   jdms_model is not initialised at all - is the 2nd occurrence supposed to refer to that? 
    4245 
     
    5962So we have a number of things to do: 
    6063 
    61 1) Correct ierr dimension to 8 in sms_medusa.F90 
    62 2) Remove duplicate variable declarations in natbio 
    63 3) Ensure missing fields are given default values in natbio 
    64 4) Replace the 2nd occurrence of jdms_input with jdms_model, presumbaly 
    65 5) Investigate why the namelist writes fail. 
     64   1. Correct ierr dimension to 8 in sms_medusa.F90 
     65   1. Remove duplicate variable declarations in natbio 
     66   1. Ensure missing fields are given default values in natbio 
     67   1. Replace the 2nd occurrence of jdms_input with jdms_model, presumably 
     68   1. Investigate why the namelist writes fail. 
    6669 
     70Checking with JP, he confirms that jdms_model is what is meant to be used in the above, with a default of 3, and jq10 should be given a default of 1.5. I've applied these to my branch and JP has also applied them to the main MEDUSA_stable branch. Ditto the ierr dimensioning fix.  
     71 
     72Further investigation into why printing natbio contents fails reveals that the FRIVER_DEP array is unallocated at time of the attempted write.  natroam seems to have similar issues with other fields.  
     73It seems that these arrays are only initialised some time after the writing of the namelist contents (if at all) in sms_medusa_alloc. The various arrays involved seem to be dimensioned by jpi, jpj and jpk.  
     74so it seems doubtful that these would ever be given values by the namelist input file! They'd hvae to be massive (over a million different values in an ORCA1 res). So is there really any point in having these 
     75as part of the namelist definition?  
     76 
     77 
     78 
     79