Changes between Version 2 and Version 3 of ticket/1851/General

Timestamp:

2017-02-22T10:18:10+01:00 (8 years ago)

Author:

frrh

Comment:

--

ticket/1851/General

@@ -22 +22 @@
    This doesn't cause a failure because its an OOB read. I suspect it would cause a failure if it was an OOB write. 
 
-   *  We then get:
+   *  We then get a failure in trc_nam_medusa.F90:
 {{{
   lib-4213 : UNRECOVERABLE library error 
@@ -33 +33 @@
 }}}
 
+   This error message doesn't lead us to any particular statement or line number which is a bit rubbish... the compiler must know but it doesn't bother to tell us. 
+
    *  trcnam_medusa.F90 has a section where it's initialising variables from the 
 natbio namelist. However it initialises jdms_input twice thus...
@@ -38 +40 @@
       jdms_input  = 3
 
-   why?
+   Why?
+
    jdms_model is not initialised at all - is the 2nd occurrence supposed to refer to that?
 
@@ -59 +62 @@
 So we have a number of things to do:
 
-1) Correct ierr dimension to 8 in sms_medusa.F90
-2) Remove duplicate variable declarations in natbio
-3) Ensure missing fields are given default values in natbio
-4) Replace the 2nd occurrence of jdms_input with jdms_model, presumbaly
-5) Investigate why the namelist writes fail.
+   1. Correct ierr dimension to 8 in sms_medusa.F90
+   1. Remove duplicate variable declarations in natbio
+   1. Ensure missing fields are given default values in natbio
+   1. Replace the 2nd occurrence of jdms_input with jdms_model, presumably
+   1. Investigate why the namelist writes fail.
 
+Checking with JP, he confirms that jdms_model is what is meant to be used in the above, with a default of 3, and jq10 should be given a default of 1.5. I've applied these to my branch and JP has also applied them to the main MEDUSA_stable branch. Ditto the ierr dimensioning fix. 
+
+Further investigation into why printing natbio contents fails reveals that the FRIVER_DEP array is unallocated at time of the attempted write.  natroam seems to have similar issues with other fields. 
+It seems that these arrays are only initialised some time after the writing of the namelist contents (if at all) in sms_medusa_alloc. The various arrays involved seem to be dimensioned by jpi, jpj and jpk. 
+so it seems doubtful that these would ever be given values by the namelist input file! They'd hvae to be massive (over a million different values in an ORCA1 res). So is there really any point in having these
+as part of the namelist definition? 
+
+
+
+