Opened 7 years ago

Closed 6 years ago

#113 closed defect (fixed)

Small bug in hydrol_soil_coef Van Genuchten parameter nvan

Reported by: clargeron Owned by: aducharne
Priority: major Milestone:
Component: Physical processes Version:
Keywords: version MICT revision 1255 Cc:

Description

!! 0.4 Local variables

INTEGER(i_std)
jsl,ji,i
REAL(r_std)
mc_ratio

!Isa

REAL(r_std)
mc_used,x,m !mc_used : contenu en eau liquide réel

m = 1.-1./nvan(ins)

THE DIMENSION OF NVAN SHOULD BE NJSC(ji) instead of INS (index of soil type).

We have to put m inside a ji=1,kjpindex loop because njsc depend of ji

Change History (9)

comment:1 Changed 7 years ago by clargeron

  • Cc clargeron added

comment:2 Changed 7 years ago by clargeron

  • Cc clargeron removed
  • Component changed from Anthropogenic processes to Physical processes
  • Owner changed from somebody to clargeron
  • Status changed from new to accepted

comment:3 Changed 7 years ago by clargeron

  • Keywords version MICT revision 1255 added

comment:4 in reply to: ↑ description Changed 7 years ago by clargeron

Replying to clargeron:


In the MICT version code revision 1255, there is an error in NVAN index :

  !! 0.4 Local variables
> 
>     INTEGER(i_std)                                    :: jsl,ji,i
>     REAL(r_std)                                       :: mc_ratio
> !Isa
>     REAL(r_std) :: mc_used,x,m !mc_used : contenu en eau liquide réel 
> 
> m = 1.-1./nvan(ins)}}}
> 
> THE DIMENSION OF NVAN SHOULD BE NJSC(ji) instead of INS (index of soil type). 
> 
> We have to put m inside a ji=1,kjpindex loop because njsc depend of ji
>     

comment:5 Changed 7 years ago by aducharne

  • Owner changed from clargeron to aducharne
  • Status changed from accepted to assigned

comment:6 Changed 7 years ago by aducharne

  • Status changed from assigned to accepted

comment:7 Changed 7 years ago by aducharne

This also true in the trunk.
In hydrol_soil_coef, change:

m = 1.-1./nvan(ins)

to

m = 1.-1./nvan(njsc(ji))

Last edited 7 years ago by aducharne (previous) (diff)

comment:8 Changed 6 years ago by jgipsl

Done in trunk rev [2397].

comment:9 Changed 6 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from accepted to closed

This must be done also in MICT branch.

Note: See TracTickets for help on using tickets.