Opened 8 years ago

Closed 8 years ago

#119 closed defect (fixed)

Uninitialized values in intersurf_gathered

Reported by: mmcgrath Owned by: jgipsl
Priority: minor Milestone:
Component: Physical processes Version:
Keywords: Cc:

Description

It seems like the indices iim and jjm are only set during the first call to intersurf_gathered (IF(l_first_intersurf)). However, they are passed to sechiba_main during every call. I think they either need to be declared as SAVE variables (using OpenMP private), or they need to be set equal to iim_g and jj_nb at every call. It is unclear to me which is the best procedure.

Change History (2)

comment:1 Changed 8 years ago by jgipsl

  • Owner changed from somebody to jgipsl
  • Status changed from new to accepted

Yes this does not seems to be correct. iim and jjm should not be used. Instead iim_g or jj_nb should be used directly. They can be acced by use module The same in all subroutines such as sechiba_main etc.

comment:2 Changed 8 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from accepted to closed

Done in rev [1692]

Note: See TracTickets for help on using tickets.