Opened 5 years ago

Closed 3 years ago

#204 closed defect (fixed)

Calls Incomplete

Reported by: ajornet Owned by: jgipsl
Priority: major Milestone: orchidee_1_9_6
Component: Driver files Version: trunc
Keywords: interface WriteField_gen orch_scatter2D_mpi_rgen Cc:

Description

If you compile with gen-interfaces and -warn interfaces the compiler throws those errors:

src_driver/weather.f90:: CALL orch_scatter2D_mpi_rgen(champout_g,champout,n3)
src_parallel/orch_write_field_p.f90:: IF (is_root_prc) CALL WriteField_gen(name,Field_g)

Let's take a look to each subroutine header:

SUBROUTINE orch_scatter2D_mpi_rgen(VarIn?, VarOut?, nbp2D, dimsize)
subroutine WriteField_gen(name, Field, NbDim?, DimSize?)

So orch_scatter2D_mpi_rgen and WriteField_gen are declared with 4 non-optional arguments. But not the lines shown at the beginning.

Fix proposal

I suggest to fix them like this:

src_driver/weather.f90

@@ -2991,7 +2991,7 @@
 #ifndef CPP_PARA
   champout(:,:)=champout_g(:,:)
 #else
-  CALL orch_scatter2D_mpi_rgen(champout_g,champout,n3)
+  CALL orch_scatter2D_mpi_rgen(champout_g,champout,SIZE(champout_g, 1),SIZE(champout_g, 2))
 #endif

src_parallel/orch_write_field_p.f90

@@ -85,7 +85,7 @@
       ALLOCATE(Field_g(iim_g,jjm_g))
       CALL Gather2D_mpi(Field,Field_g)
 
-      IF (is_root_prc) CALL WriteField_gen(name,Field_g)  
+      IF (is_root_prc) CALL WriteField_gen(name,Field_g,2,Dim)  
       
       DEALLOCATE(Field_g)
   END SUBROUTINE WriteField_2d_p

Change History (3)

comment:1 Changed 5 years ago by ajornet

I commieted to my personal svn, revision r2946.

comment:2 Changed 5 years ago by jgipsl

  • Owner changed from somebody to jgipsl
  • Status changed from new to accepted

comment:3 Changed 3 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from accepted to closed

Done in the trunk rev [4195]

Note: See TracTickets for help on using tickets.