Opened 5 years ago

Last modified 14 months ago

#245 accepted defect

Clarify the coding and usage of frac_nobio

Reported by: jpolcher Owned by: maignan
Priority: major Milestone: Not scheduled yet
Component: Physical processes Version: trunc
Keywords: Cc:

Description

An analysis of the usage of frac_nobio in the model (https://forge.ipsl.jussieu.fr/orchidee/wiki/Documentation/Frac_Nobio) has revealed some issues which need to be addressed. This will clarify the code and allow new evolutions which are planed.

frac_nobio and totfrac_nobio contain redundant information as totfrac_nobio=SUM(frac_nobio) over nnobio. But both are passed to most subroutines and nowhere is it verified that the information matches.

The code would be much more easier to follow if only frac_nobio would be passed. When totfrac_nobio is needed the sum would be done locally.

totfrac_nobio is for instance the only variable used for STOMATE and this is logical. So at least slowproc.f90 will need to compute this variable to pass it to STOMATE.

The other issue is that there is no guarantee that the model conserves all stocks if frac_nobio changes over time. So the model should check that frac_nobio does not change. Especially in slowproc.f90 where frac_nobio can change with the reading and interpolation of the PFT maps.

Furthermore the introduction of nnobio has not been done fully. Many other variables need to have this dimension as well, for instance the parameters to be used on the surfaces other than ice.

Change History (4)

comment:1 Changed 4 years ago by jgipsl

  • Owner changed from somebody to maignan
  • Status changed from new to assigned

comment:2 Changed 4 years ago by maignan

  • Component changed from Anthropogenic processes to Physical processes
  • Milestone set to ORCHIDEE 3.0
  • Status changed from assigned to accepted
  • Version set to trunc

comment:3 Changed 2 years ago by maignan

  • Milestone changed from ORCHIDEE 3.0 to ORCHIDEE 4.0

comment:4 Changed 14 months ago by luyssaert

  • Milestone changed from ORCHIDEE 4.0 to Not scheduled yet
Note: See TracTickets for help on using tickets.