Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32 closed enhancement (fixed)

ipslerr should be level 3 in hydrol.f90

Reported by: jgipsl Owned by: jgipsl
Priority: major Milestone: ORCHIDEE 1.9.7
Component: Physical processes Version:
Keywords: Cc:

Description

Too many ipslerr are set to level 2 (that means only warning) in cases when diagnosed error should lead to stop the model at least in hydrol.f90.

In hydrol.f90 rev 1042, all ipslerr in option check_cwrr should be set to 3 (lign 3806, 3830, 3851, 4727, 4760, 4803, 4832). All ipslerr in hydrol_waterbal which is called if check_waterbal=true, should also be set to 3 (lign 5206, 5255).

At same time, we should change "STOP 1" to ipslerr(3).

Change History (3)

comment:1 Changed 9 years ago by jgipsl

Il est utile de voir toute la série des erreurs lors de la non-conservation avant de planter le modèle.

La meilleur solution serait d'incrémenter un nb_error à chaque ipslerr(2, ...) et puis en fin si nb_error>0 arrêter le modèle.

A bientot

Jan

comment:2 Changed 9 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from new to closed

Each ipslerr will lead to a stop. In the case a subroutine has several ipslerr, then the model will continue to the end of subroutine and stop if one or several errors where found.

Done in commit 1057.

comment:3 Changed 9 years ago by dsolyga

  • Milestone changed from ORCHIDEE 2.0 to ORCHIDEE 1.9.7
Note: See TracTickets for help on using tickets.