Opened 5 years ago

Closed 4 years ago

#323 closed enhancement (fixed)

hydrol_waterbal: tot_water_end and link with twbr

Reported by: aducharne Owned by: jpolcher
Priority: minor Milestone: IPSLCM6.v1
Component: Physical processes Version: trunc
Keywords: Cc:

Description

tot_water_beg and tot_water_end are used for water conservation checks in hydrol_waterbal

1) In hydrol_finalize, restput of tot_water_end is put in the restart file (restput) under the name 'tot_water_beg' => is it normal? (1+1)

2) Given we now export TWBR at each time step, is hydrol_waterbal still useful apart from updating tot_water_beg as tot_water_end at the end of each time step?

Change History (3)

comment:1 Changed 4 years ago by jgipsl

1) This is weird but it is working because after tot_water_beg has been read from restart file, in hydrol_waterbal_init :

tot_water_end(:) = tot_water_beg(:)

comment:2 Changed 4 years ago by aducharne

Concernant le point 2, les subroutines hydrol_waterbal, et hydrol_waterbal_init, ne servent qu'à des actions contrôlées par IF(check_waterbal).
Jan est d'accord que ces actions sont redondantes avec ce qui actuellement fait via TWBR, et il est OK pour supprimer ce qui relève de check_waterbal.

Après une nouvelle vérification, on peut donc supprimer:

  • les 2 subroutines hydrol_waterbal_init et hydrol_waterbal
  • tout ce qui est contrôlé par IF (check_waterbal) dans hydrol.f90, y compris xios_orchidee_send_field("tot_flux",tot_flux/dt_sechiba), et les restput/restget sur 'tot_water_beg'
  • les déclarations et allocations de tot_flux, tot_water_beg, et tot_water_end, qui ne servent qu'avec check_waterbal
  • dans les xml, on peut supprimer "tot_flux"

comment:3 Changed 4 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from new to closed

Done in rev [4727]

Note: See TracTickets for help on using tickets.