Opened 9 years ago

Closed 7 years ago

#34 closed defect (fixed)

The standard value of dpu_max should be different in the Choisnel and CWRR versions

Reported by: aducharne Owned by: aducharne
Priority: major Milestone: ORCHIDEE 2.0
Component: Physical processes Version:
Keywords: Cc:

Description

In the trunk, constantes_soil.f90:
REAL(r_std),SAVE :: dpu_max = 4.0_r_std !! Maximum depth of soil reservoir. (m)

This default value is the one used in the CMIP5 runs with the Choisnel version of ORCHIDEE.
It is not appropriate for the CWRR version, which has been developed to use 11 soil layers in a 2-m soil. Changing the total soil depth dpu_max leads to thicker soil layers, which are not adapted anymore to accurately describe the soil moisture gradients and the resulting water fluxes in the top soil layers.

The solution would be to define dpu_max like humcste in pft_parameters.f90:

IF (active_flags%hydrol_cwrr ) THEN

dpu_max = 2.0_r_std

ELSE

dpu_max = 4.0_r_std

END IF

Change History (7)

comment:1 follow-up: Changed 9 years ago by jpolcher

Choisnel is defined by default over 2m and validated in this configuration. It is the responsibility of the user if he wishes to change that to 4m.

So in all cases dpu_max = 2.0 and if people want to change that it is at their own risk.

CWRR does not seem to be affected by dpu_max = 2.0 ! The tests I did with HydroMerge? and the Trunk only show very small differences in the RootMoist? variable (+-60kg/m²). In the Trunk the RootMoist? goes up to 780kg/m² which is incompatible with a 4m soil.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 9 years ago by jpolcher

Replying to jpolcher:

Choisnel is defined by default over 2m and validated in this configuration. It is the responsibility of the user if he wishes to change that to 4m.

So in all cases dpu_max = 2.0 and if people want to change that it is at their own risk.

CWRR does not seem to be affected by dpu_max = 2.0 ! The tests I did with HydroMerge? and the Trunk only show very small differences in the RootMoist? variable (+-60kg/m²). In the Trunk the RootMoist? goes up to 780kg/m² which is incompatible with a 4m soil.

Sorry, I meant "CWRR does not seem to be affected by dpu_max = 4.0 !"

comment:3 in reply to: ↑ 2 Changed 9 years ago by peylin

Replying to jpolcher:

Replying to jpolcher:

Choisnel is defined by default over 2m and validated in this configuration. It is the responsibility of the user if he wishes to change that to 4m.

So in all cases dpu_max = 2.0 and if people want to change that it is at their own risk.

CWRR does not seem to be affected by dpu_max = 2.0 ! The tests I did with HydroMerge? and the Trunk only show very small differences in the RootMoist? variable (+-60kg/m²). In the Trunk the RootMoist? goes up to 780kg/m² which is incompatible with a 4m soil.

Sorry, I meant "CWRR does not seem to be affected by dpu_max = 4.0 !"

I have some probleme with setting the default value to 2 meter with Choisnel while 4 meter was use for the CMIP5 simulations!
I think there was some old tests showing that moving to 4 meters (although unrealistic at temperate latitudes) does not change the results of the simulations too much (LE, temperature,...), given the exponential profile of the root distribution. However, it does improve significantly over the tropics (we have done some optimization with fluxnet sites and there is clearly a need for higher than 2 meter soil depth).
But maybe for the temperate and high latitudes the use of 4m has a strong impact on the runoff, something that i do not know ?
So i would still keep a default of 4m before as used in CMIP5!
Philippe

comment:4 in reply to: ↑ description Changed 9 years ago by dsolyga

Replying to aducharne:

In the trunk, constantes_soil.f90:
REAL(r_std),SAVE :: dpu_max = 4.0_r_std !! Maximum depth of soil reservoir. (m)

This default value is the one used in the CMIP5 runs with the Choisnel version of ORCHIDEE.
It is not appropriate for the CWRR version, which has been developed to use 11 soil layers in a 2-m soil. Changing the total soil depth dpu_max leads to thicker soil layers, which are not adapted anymore to accurately describe the soil moisture gradients and the resulting water fluxes in the top soil layers.

The solution would be to define dpu_max like humcste in pft_parameters.f90:

IF (active_flags%hydrol_cwrr ) THEN

dpu_max = 2.0_r_std

ELSE

dpu_max = 4.0_r_std

END IF

It is already done in the current version of the trunk. Even if dpu_max = 4.0 in constantes_soil, it is overwritten in intsurf_config subroutine :

    IF ( control_flags%hydrol_cwrr ) THEN
       dpu_max = 2.0
    ELSE
       dpu_max = 4.0
    END IF

    !Config Key   = HYDROL_SOIL_DEPTH
    !Config Desc  = Total depth of soil reservoir
    !Config If    = OK_SECHIBA 
    !Config Def   = 4.
    !Config Help  = By default, ORCHIDEE uses the AR5 configuration (Choisnel-4m).
    !Config Units = [m]
    !  	 	 
    CALL getin_p ("HYDROL_SOIL_DEPTH", dpu_max)

Maybe given a default value is a bit disturbing. We could only declare dpu_max in constantes_soil without initializing it.

comment:5 Changed 8 years ago by peylin

  • Owner changed from somebody to aducharne
  • Status changed from new to assigned

comment:6 Changed 8 years ago by aducharne

  • Status changed from assigned to accepted

comment:7 Changed 7 years ago by aducharne

  • Resolution set to fixed
  • Status changed from accepted to closed

Already done in code, small clarification added in rev [1855]

Note: See TracTickets for help on using tickets.