Opened 4 years ago

Closed 4 years ago

#354 closed defect (fixed)

non-standard logical operation in restcom.f90

Reported by: pmaugis Owned by: jgipsl
Priority: minor Milestone:
Component: Tools Version: trunc
Keywords: Cc:

Description

dans /IOIPSL/src/restcom.f90 (rev. 2020), ligne 842, il semblerait que l'un des tests ne soit pas complètement correct

iret = NF90_CREATE(fname,cmode=or(NF90_NOCLOBBER,NF90_64BIT_OFFSET),ncid=ncfid)

Ici, l'utilisation du OR est non standard car il s'agit implicitement d'un OU binaire et non logique. Il faudrait donc écrire IOR à la place du OR. Cette correction est importante pour les algorithmes de différentiation automatique de code.

Est-ce que vous pouvez procéder à la modification, SVP ?

Change History (2)

comment:1 Changed 4 years ago by jgipsl

  • Owner changed from somebody to jgipsl
  • Status changed from new to accepted

comment:2 Changed 4 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from accepted to closed

Done in IOIPSL trunk : http://forge.ipsl.jussieu.fr/igcmg/changeset/3374

This modification will be included in the next coming tag of IOIPSL v2_2_4, planed to be created in the end of September.

Note: See TracTickets for help on using tickets.