Opened 4 years ago

Closed 2 years ago

#397 closed enhancement (fixed)

Can we get rid of temp_hydro and hydrol_calculate_temp_hydro in hydrol?

Reported by: aducharne Owned by: maignan
Priority: minor Milestone: ORCHIDEE 3.0
Component: Physical processes Version:
Keywords: Cc:

Description

Given that the soil moisture and heat diffusion schemes share the same vertical distribution, is it still necessary to keep the variable temp_hydro in hydrol.f90, and the subroutine hydrol_calculate_temp_hydro which only serves to calculate it?

Similar simplifications have been done with frac_hydro_diag and subroutine hydrol_calculate_frac_hydro_diag, see Tiket #195.

Agnès and Josefine

Change History (2)

comment:1 Changed 3 years ago by aducharne

I suggest to replace temp_hydro by stempdiag. See below,
Agnès

In hydrol_calculate_temp_hydro:

intfactt give the overlap between the thermal and hydrological layers => should be one with the shared VD
6722 intfactt(jh,jsl) = MAX(MIN(lev_diag,lev_prog)-MAX(prev_diag, prev_prog),&
6723 & 0.0)/(lev_diag-prev_diag)

6732 temp_hydro(:,:)=0.
6733 DO jsl= 1, nslm
6734 DO jh= 1, nslm
6735 DO ji = 1, kjpindex
6736 temp_hydro(ji,jh) = temp_hydro(ji,jh) + stempdiag(ji,jsl)*intfactt(jh,jsl)
6737 ENDDO
6738 ENDDO
6739 ENDDO

In thermosoil (_initialize and _profile):
stempdiag(:,:) = ptn(:,1:nslm)

comment:2 Changed 2 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from new to closed

Done in the trunk [6372] on common accord CO, FM, AD, BG.

Note: See TracTickets for help on using tickets.