Opened 9 years ago

Closed 9 years ago

#43 closed enhancement (fixed)

Parameters simplification and definition (pft_parameters)

Reported by: dsolyga Owned by: dsolyga
Priority: minor Milestone: ORCHIDEE 1.9.7
Component: Model architecture Version: orchidee_1_9_6
Keywords: parameters, cleaning Cc:

Description

  • Many pft parameters are redundant like tree and is_tree. Besides, some parameters like is_tree, is_needleleaf, is_evegreen, etc should not be externalized. They have to be defined internally. For instance, is_tree can be defined from leaf_tab :
       is_tree(:) = .FALSE.
       DO jv = 1,nvm
          IF ( leaf_tab(jv) <= 2 ) is_tree(jv) = .TRUE.
       END DO
    
  • Actually, the parameters is_tree, is_deciduous, is_evergreen and is_needleleaf could be derived from the parameters leaf_tab and pheno_model :
       !! Define labels from physiologic characteristics 
       !
       leaf_tab(:) = leaf_tab_mtc(pft_to_mtc(:)) 
       pheno_model(:) = pheno_model_mtc(pft_to_mtc(:))   
       !
       is_tree(:) = .FALSE.
       DO jv = 1,nvm
          IF ( leaf_tab(jv) <= 2 ) is_tree(jv) = .TRUE.
       END DO
          !
       is_deciduous(:) = .FALSE.
       DO jv = 1,nvm
          IF ( is_tree(jv) .AND. (pheno_model(jv) /= "none") ) is_deciduous(jv) = .TRUE.
       END DO
       !
       is_evergreen(:) = .FALSE.
       DO jv = 1,nvm
          IF ( is_tree(jv) .AND. (pheno_model(jv) /= "none") ) is_evergreen(jv) = .TRUE.
       END DO
       !
       is_needleleaf(:) = .FALSE.
       DO jv = 1,nvm
          IF ( leaf_tab(jv) == 2 ) is_needleleaf(jv) = .TRUE.
       END DO
    
    

So only leaf_tab and pheno_model have to be externalized. Currently, is_needleleaf is not used but it will be used by the forest management module.
The following parameters could also be deleted in pft_parameters :

    is_summergreen
    is_broadleaf
    is_temperate
    is_boreal
  • It is proposed to unify tree and is_tree. tree is redundant and is used only by stomate. So the task consists also to replace all "tree"in stomate by "is_tree".

Modules concerned

pft_parameters, constantes_mtc, almost all the stomate modules.

Validation test

Trivial binary test. The implementation is nearly done.

Change History (3)

comment:1 Changed 9 years ago by nvuilsce

For is_evergreen, it should be set as:

    is_evergreen(:) = .FALSE.
    DO jv = 1,nvm
       IF ( is_tree(jv) .AND. (pheno_model(jv) == "none") )
 is_evergreen(jv) = .TRUE.
    END DO

comment:2 Changed 9 years ago by dsolyga

Test done on Obelix (global, 1D) : no changes in results. See commit [1091].

comment:3 Changed 9 years ago by dsolyga

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.