Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#471 closed defect (fixed)

Restartability was lost when including nitrogen branch in the trunk

Reported by: jgipsl Owned by: mmcgrath
Priority: blocker Milestone: ORCHIDEE 3.0
Component: Anthropogenic processes Version:
Keywords: Cc:

Description

Restartability, also called 1+1=2, was lost when including nitrogen branch in the trunk. This has to be re-established.

See also ticket #469

Attachments (1)

bug.pdf (60.0 KB) - added by mmcgrath 2 years ago.
How I found and fixed one of the bugs

Download all attachments as: .zip

Change History (6)

comment:1 Changed 2 years ago by mmcgrath

  • Owner changed from jgipsl to mmcgrath
  • Status changed from new to accepted

comment:2 Changed 2 years ago by jgipsl

Correction done in the trunk rev [5690]

Changed 2 years ago by mmcgrath

How I found and fixed one of the bugs

comment:3 Changed 2 years ago by mmcgrath

One problem was in slowproc:

! Calculate siltfraction not needed to be in restart file
IF ( ALL( sandfraction(:) .EQ. val_exp) ) THEN
siltfraction(:) = val_exp
ELSE
siltfraction(:) = 1. - clayfraction(:) - sandfraction(:)
END IF

By removing this code and reading in siltfraction from the restart file, it appears to go away.

comment:4 Changed 2 years ago by mmcgrath

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in trunk revision 5733.

Last edited 2 years ago by mmcgrath (previous) (diff)

comment:5 Changed 2 years ago by jgipsl

See the commit here [5733]

Note: See TracTickets for help on using tickets.