Opened 5 years ago

Closed 5 years ago

#576 closed defect (fixed)

Negative circ_class_kill_pot

Reported by: jjeong Owned by: luyssaert
Priority: minor Milestone: IPSLCM6.v2
Component: Anthropogenic processes Version:
Keywords: Cc:

Description

In sapiens_forestry,
during thinning, negatvie probability is calculated possibly due to the largest circ class doesn't have the biggest biomass, resulting in negative circ_class_kill_pot.

For now, by setting hack_circ_class = y in run.def, probability can be forced to zero.

Change History (2)

comment:1 Changed 5 years ago by luyssaert

  • Owner changed from somebody to luyssaert
  • Status changed from new to assigned

The code assumes that the biomass of the different circumference classes is stored in ascending order in circ_class_biomass. On top of that it was assumed that if this is the case, that the circumferences of each class will also be sorted. The latter assumption is not true in case of allocation under C-limitation (not enough carbon to allocate leaves/roots to all circ classes). In that case biomass (which also depends on roots and leaves) may be out of order with the circumference (which mostly depends on heartwood). More explaination on the issue in the code.

Solution: See r6166. MINVAL and MAXVAL were used in the thinning subroutine instead of assuming that the min and max value can be found in the first and last circ class.

Last edited 5 years ago by luyssaert (previous) (diff)

comment:2 Changed 5 years ago by luyssaert

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.