Opened 4 years ago

Closed 4 years ago

#595 closed defect (duplicate)

wrong argument dimensions for stempdiag in nitrogen_dynamics

Reported by: ajornet Owned by: nvuilsce
Priority: critical Milestone: ORCHIDEE 3.0
Component: Biogeochemical processes Version: trunc
Keywords: nitrogen stempdiag Cc:

Description

In stomate_main:

stempdiag is declared as:

REAL(r_std),DIMENSION(kjpindex,nslm),INTENT(in) :: stempdiag         !! Soil temperature (K)

Then it's given as an argument to nitrogen_dynamics:

IF(ok_ncycle) THEN
       CALL nitrogen_dynamics(kjpindex, clay, MAX(zero, un - silt - clay), &
            stempdiag-tp_00, tmc_pft, drainage_pft, runoff_pft, swc_pft, veget_cov_max, resp_total_soil, som, &
            biomass, n_input, soil_ph, n_mineralisation, pb, &
            n_uptake, bulk,soil_n_min,p_O2,bact, N_support, cn_leaf_min_2D, &
            cn_leaf_max_2D, cn_leaf_init_2D)
ENDIF

Nitrogen dynamics is defined as:

  SUBROUTINE nitrogen_dynamics(npts, clay, sand, &
     temp_sol, tmc_pft, drainage_pft, runoff_pft, swc_pft, veget_max, resp_sol, &
     som, biomass, input, pH, &
     mineralisation, pb, plant_uptake, Bd,soil_n_min, &
     p_O2,bact, N_support, &
     cn_leaf_min_2D, cn_leaf_max_2D, cn_leaf_init_2D)
  ...
  REAL(r_std), DIMENSION(npts), INTENT(in)  :: temp_sol ! soil temperature (degC)
  ...

There is a dimension missmatch between the given argument (2 dimensions) and its definition (1 dimension). This can cause random errors between simulations.

Change History (2)

comment:1 Changed 4 years ago by ajornet

  • Owner changed from somebody to nvuilsce
  • Status changed from new to assigned

comment:2 Changed 4 years ago by jgipsl

  • Resolution set to duplicate
  • Status changed from assigned to closed

This ticket is duplicated in #600

Note: See TracTickets for help on using tickets.