Opened 9 years ago

Closed 7 years ago

#64 closed enhancement (wontfix)

Harmonize argument lists

Reported by: luyssaert Owned by: jgipsl
Priority: minor Milestone: ORCHIDEE 2.0
Component: Model architecture Version:
Keywords: Cc:

Description

In stomate_lpj (but also in other subroutines) long argument lists are passed from one routine to another. Many of these variables are diagnostic and be be recalculated whenever needed rather than being passed. Recalculating would result in a cleaner code but it may require more computation time. If every recalculation of a variable makes use of the same subroutine/function errors could be easily corrected and changed.
Fore example: woodmass_ind, height, ...

Change History (3)

comment:1 Changed 8 years ago by nvuilsce

I think we need to discuss this issue prior to take any decision.
One possible risk of this implementation is to get maybe several values for one variable for one time step because some variables are redefined more than once per time step.

comment:2 Changed 8 years ago by peylin

  • Owner changed from somebody to jgipsl
  • Status changed from new to assigned

comment:3 Changed 7 years ago by jgipsl

  • Resolution set to wontfix
  • Status changed from assigned to closed

Ticket meeting 4 mars 2014 : AD, NVui, JG

This is not specific to stomate_lpj and must be treated as a global guiding line question. We wont go further with this topic for the moment.

Note: See TracTickets for help on using tickets.