Opened 2 years ago
Closed 16 months ago
#780 closed defect (fixed)
Definition of so_capa_dry and so_cond_dry in thermoil
Reported by: | aducharne | Owned by: | aducharne |
---|---|---|---|
Priority: | minor | Milestone: | ORCHIDEE 3.0 |
Component: | Physical processes | Version: | |
Keywords: | Cc: |
Description
For Trunk and Branch_2_2:
1) so_cond_dry is not used => to be removed
2) so_capa_dry is used in thermosoil, but under the name so_capa_dry_ns, with values coming from the tabulated values of constantes_soil_var.f90, as a function of texture. In constantes_soil.f90, howver, we can define a scalar so_capa_dry from the run.def
=> we should use a single name everywhere (so_capa_dry), and ensure that the value from the run.def can override the ones deduced from texture: by adding USE constantes_soil_var in thermosoil? is it enough? what about restarts ?
=> in thermosoil_initialize, we should change the dimension of so_capa_dry at the following line, introducing jsc=njsc(ji) to relate to soil texture
so_capa_ice(:) = so_capa_dry + mcs(:)*capa_ice*rho_ice
Change History (6)
comment:1 Changed 2 years ago by aducharne
- Component changed from Anthropogenic processes to Physical processes
- Milestone set to ORCHIDEE 4.1
- Owner changed from somebody to aducharne
- Priority changed from major to minor
- Status changed from new to accepted
comment:2 Changed 23 months ago by jgipsl
comment:3 Changed 22 months ago by maignan
Point 2) See correction proposed in Ticket #809.
comment:4 Changed 19 months ago by jgipsl
- Milestone changed from ORCHIDEE 4.1 to ORCHIDEE 3.0
Implementation done in rev [7508] in branch ORCHIDEE_2_2
This ticket is now done for branch 2_2 and the trunk.
Should it also be done in branch ORCHIDEE_3 ? I move the ticket to milesone ORCHIDEE 3 while waiting for a decision.
comment:5 Changed 16 months ago by nvuilsce
Done in ORCHIDEE 3 commit [7634]
comment:6 Changed 16 months ago by nvuilsce
- Resolution set to fixed
- Status changed from accepted to closed
Implementation done in rev [7348] in the trunk