mass balance error in stomate_allocation

[jgipsl]

Following mass balance error was found when running LMDZ-ORCHIDEE:

206 Entering functional allocation growth
206 Error: mass balance is not closed in stomate_allocation for carbon
206  ipts, ivm;            2          11
206  Difference is,   6.591096395401774E-002
206  pool_end,pool_start:    27.9604997127654 27.1165214297789
206
206FATAL ERROR FROM ROUTINE stomate_allocation
206 --> Mass balance error
206 -->
206 -->
206

Set up:

• Using revision 7293 of the trunk ORCHIDEE and LMDZ6/trunk revision 3651 and configuration LMDZOR_v6.4_work
• Experience LMDZOR/clim_pdControl
• Starting 1995-01-01 the simulation crashes in 1995-03-22 when running by PeriodLength=1M.
• Compilation mode=prod
• Tests only done at Jean-Zay, IDRIS

ERR_ACT=1 will be set in configuration LMDZOR_v6.4 while waiting for a solution of this ticket.

[jgipsl]

ERR_ACT=1 is set temporary in orchidee.def in LMDZOR_v6.4 simulation setup :
​https://forge.ipsl.jussieu.fr/igcmg/changeset/5922

The value to keep as default for coupled simulations should be discussed when current ticket has been resolved.

[jgipsl]

Using [7450] test above over 5Y are ok at jean-zay and irene, using ERR_ACT=3.

[luyssaert]

The same block of code was repeated several times in r7450. In r7491 this code is moved into a subroutine. One intermediate mass balance check was not functioning in r7450, this check (labelled 3c) was fixed and activated.