Opened 2 years ago

Closed 21 months ago

#799 closed defect (fixed)

Integrate the developments of Salma from 2.2 into the trunk

Reported by: bguenet Owned by: bguenet
Priority: major Milestone: ORCHIDEE 4.1
Component: Anthropogenic processes Version:
Keywords: Cc:

Description

Salma during her Ph.D develloped a way to read more easily new map of soil texture or even maps of parameters for hydrol. Agnes add these modifications in the 2.2 (tickets r6954 r7200 r7239). It should be integrated into the trunk

Change History (8)

comment:1 Changed 2 years ago by luyssaert

  • Milestone changed from ORCHIDEE 4.3 to ORCHIDEE 4.1

comment:2 Changed 2 years ago by bguenet

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 follow-up: Changed 2 years ago by bguenet

Done in rev [7377] : this takes into account following changsets done on the branch ORCHIDEE_2_2: [6954], [7239], [7260]

Still to be done: [7325], [7200]

To checked: [7432], [7375]

Last edited 22 months ago by jgipsl (previous) (diff)

comment:4 Changed 22 months ago by jgipsl

For record: changeset [7377] showed changes in results seen by the trusting. Among the changes done in the commit, only the 2 following in hydrol.f90 are responsible for the change in results:

1) In following lines, the borne 0,1 are added :

    DO jv=1,nvm
       tmc_pft(:,jv)      = MAX(tmc(:,pref_soil_veg(jv)),tmcr(:,pref_soil_veg(jv)))
       swc_pft(:,jv)      = MIN(un, (MAX(zero, (( tmc(:,pref_soil_veg(jv))  tmcr(:,pref_soil_veg(jv)) ) &
            / ( tmcs(:,pref_soil_veg(jv)) - tmcr(:,pref_soil_veg(jv)))))))
    ENDDO

2) The calculation of kfact_root changed (in hydrol_soil). It know goes over all soil layers instead of stopping at root_depth

comment:5 in reply to: ↑ 3 Changed 22 months ago by jgipsl

Integrated changes done in [7325] and [7200] into the trunk in [7496]

comment:6 follow-up: Changed 22 months ago by jgipsl

  • Resolution fixed deleted
  • Status changed from closed to reopened

Before closing the ticket: To be checked: [7432], [7375] (Bertrand)

comment:7 in reply to: ↑ 6 Changed 21 months ago by jgipsl

Replying to jgipsl:

Before closing the ticket: To be checked: [7432], [7375] (Bertrand)

These 2 changesets have been introduced previously in the trunk.

This ticket seems ready to be closed.

comment:8 Changed 21 months ago by bguenet

  • Resolution set to fixed
  • Status changed from reopened to closed

Done in [7536]. We close the ticket

Note: See TracTickets for help on using tickets.