Opened 10 years ago

Closed 5 years ago

#83 closed task (fixed)

Usefulness of the routine thermosoil_energy

Reported by: nvuilsce Owned by: fuxing
Priority: major Milestone: ORCHIDEE 2.0
Component: Physical processes Version: orchidee_1_9_6
Keywords: cleaning thermosoil Cc:

Description

The purpose of the routine thermosoil_energy needs to be clarified. Is it really useful ? - Comment of I. Gouttevin

Change History (4)

comment:1 Changed 10 years ago by nvuilsce

  • Owner changed from somebody to jpolcher
  • Status changed from new to assigned

comment:2 Changed 5 years ago by jgipsl

  • Owner changed from jpolcher to fuxing

comment:3 Changed 5 years ago by jgipsl

Following has been written by Fuxing after the Orchidee Day Sept 2017 in https://docs.google.com/document/d/1Bm6i7QiiF3JxRT5WKoICwXA_GIwl68AuLTJ_nlx43tI/edit#

Four related variables in thermosoil_energy:

  • (1) variables coldcont_incr and surfheat_incr computed in thermosoil_energy, output as DelColdCont and DelSurfHeat (Accumulated change in surface layer cold content and heat; CMIP6 variables?);
  • (2) temp_sol_beg used to compute coldcont_incr and surfheat_incr;
  • (3) ptn_beg used by SUBROUTINE thermosoil_readjust.

Suggestion:

  • (1) if DelColdCont and DelSurfHeat are not needed: remove thermosoil_energy (including variables coldcont_incr, surfheat_incr and temp_sol_beg); move ‘ptn_beg(:,:) = ptn(:,:)’ from ‘thermosoil_energy’ to ‘SUBROUTINE thermosoil_main’ (after CALL thermosoil_profile).
  • (2) if DelColdCont and DelSurfHeat are necessary: keep thermosoil_energy as it is, but change description of this SUBROUTINE.

comment:4 Changed 5 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from assigned to closed

A mix of solution 1 and 2 has been done in the trunk rev [4682]:

  • subroutine is kept but renamed
  • ptn_beg=ptn is moved to thermosoil_main
Note: See TracTickets for help on using tickets.