Opened 9 years ago

Closed 4 years ago

#96 closed defect (fixed)

check the criteria of test .GT. zero in the code

Reported by: nicolasviovy Owned by: jgipsl
Priority: major Milestone:
Component: Model architecture Version:
Keywords: undeflow/oveflow Cc:

Description

Arsène found a problem in lpj_pftinout where ther is a test:

'WHERE (veget_max(:,j) .GT. zero)'

that gives wrong result because of a division by very small veget_max.

I found similar problem several time in OCN so I think we need to check and change in all the code the statements 'WHERE (xx .GT. zero)' by 'WHERE (xx .GT. min_stomate)' or '(xx .GT. min_sechiba)' where xx is used as denominator to avoid these problems of underflow/overflow.

Change History (4)

comment:1 Changed 8 years ago by peylin

  • Owner changed from somebody to jgipsl
  • Status changed from new to assigned

comment:2 Changed 8 years ago by jgipsl

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by jgipsl

Done in lpj_pftinout [1995]

comment:4 Changed 4 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from accepted to closed

Done in the trunk [4624]

Note: See TracTickets for help on using tickets.