Changes between Version 24 and Version 25 of DevelopmentActivities/Bugs


Ignore:
Timestamp:
12/14/15 08:52:18 (5 years ago)
Author:
ajornet
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevelopmentActivities/Bugs

    v24 v25  
    99Supposedly solved at r3021 and r3022. It seems that it is not the case. 
    1010 
    11 Update: negative values at diff_frac.  
     11There are negative values at diff_frac in stomate_litter. 
     12 
     13It only fails when DGVM is active. 
     14 
     15I disscussed it with Chao, he thinks it comes from somewhere else. I also disscussed with Dan about DGVM. She did not find anything. 
     16 
     17It remains to check if this is a problem related only to precission. Due to the use of min_stomate. 
     18 
     19 
    1220 
    1321=== Multiple floating point exceptions at reat_of_spread === 
     
    5058}}} 
    5159 
     60Attention: the use of WHERE statement with min_stomate is a bad practice which leads to potential bugs. What if the value is negative? In this case it would be ignored. 
    5261 
    5362== River routing == 
     
    7281In Albert's branch, we have two possible different sets of values for soil_capa and soil_cond based on the keyword SOIL_LAYERS_DISCRE_METHOD (see constantes_soil.f90 and get_discretization_constants in thermosoil.f90). 
    7382 
    74 This gives access to two different vertical discretization shemes (see thermosoil_levels). I copied all this relevant code below. 
     83This gives access to two different vertical discretization schemes (see thermosoil_levels). I copied all this relevant code below. 
    7584 
    7685 
     
    79882. I have the impression that soil_capa and soil_cond may intervene elsewhere, do we still keep the two different sets of values? 
    8089 
     90Note: this is a good opportunity to introduce unit tests. 
    8191 
    8292== Forcesoil ==