Changes between Version 21 and Version 22 of DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation


Ignore:
Timestamp:
12/07/15 10:57:38 (5 years ago)
Author:
maignan
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

    v21 v22  
    1 = Evaluation = 
    2  
    3 == Notes from M. Guimberteau == 
    4  
    5 === 2015/08/27 === 
    6  
    7 * Bugs 
    8  
    9 '''In stomate_wet_ch4_pt_ter_0.f90''' 
     1= Solved Issues = 
     2 
     3== Bug report in stomate_wet_ch4_pt_ter_0.f90 by M. Guimberteau on 2015/08/27 == 
    104 
    115The following parameters need to be defined and this part of the code should be added: 
     
    2317Albert: changed r2906 
    2418 
    25 === 2015/08/24 === 
    26  
    27 * Bugs 
    28  
    29 '''In thermosoil''' 
     19 
     20== Bug report in thermosoil by M. Guimberteau on 2015/08/24 == 
    3021 
    3122The variable SoilTemp should be in the almaoutput condition of the loop and related to ptn_pftmean and not ptn: 
     
    6657Albert: done in r2907. 
    6758 
    68 '''In intersurf and ioipslctrl''' 
     59== Bugs report in intersurf and ioipslctrl by M. Guimberteau on 2015/08/24 == 
    6960 
    7061The variable ptn_snow_pftmean does not exist in the code anymore. The call histdef should be removed: 
     
    9687 
    9788 
    98 ---- 
    99  
    100  
    101 == Notes from F. Maignan == 
    102  
     89== Bug report in thermosoil.f90 / thermosoil_finalize by F. Maignan on 2015/09/10 & 2015/08/31 == 
    10390I've started a 2 degree V6 evaluation at LSCE here:[[BR]] 
    10491/home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl/modeles/ORCHIDEE/modipsl/config/ORCHIDEE_OL/OOL_SEC_STO_V6[[BR]] 
    10592 
    106 The modified code is in /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl 
    107  
    108  
    109 === '''Bugs''' === 
    110 * '''thermosoil.f90 / thermosoil_finalize''' (2015/09/10 & 2015/08/31)  
     93The modified code is in /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl[[BR]] 
     94 
    11195The gthick, gtemp and gpkappa variables were not saved in the restart file.[[BR]] 
    11296The following correction should be applied: 
     
    145129Albert: done in r2909. 
    146130 
    147 * '''stomate.f90 / call writerestart''' (2015/08/27) 
     131== Bug report in stomate.f90 / call writerestart by F. Maignan on 2015/08/27 == 
    148132The following correction should be applied: 
    149133{{{ 
     
    160144Albert: done in r2910. 
    161145 
    162 * '''lpj_spitfire.f90 / spitfire''' (2015/08/27) 
     146== Bug report in lpj_spitfire.f90 / spitfire by F. Maignan on 2015/08/27 == 
    163147Add: 
    164148{{{ 
     
    171155Albert: done in r2910. 
    172156 
    173 * '''stomate_permafrost_carbon.f90 / snow_interpol / ! 5. inter- or extrapolate''' (2015/08/24)[[BR]] 
     157== Bug report in stomate_permafrost_carbon.f90 / snow_interpol / ! 5. inter- or extrapolate by F. Maignan on 2015/08/24 == 
    174158{{{ 
    175159IF ( dzio(ip,iv) .GT. 0. ) THEN 
     
    183167Albert: done in r2910. 
    184168 
    185 * '''stomate_Cforcing_name and stomate_forcing_name''' (2015/08/21) 
     169== Bug report in stomate_Cforcing_name and stomate_forcing_name by F. Maignan on 2015/08/21 == 
    186170I've found a problem with the variable Cforcing_name, which is declared both as a global save variable of the stomate module and as a save variable of the stomate_main procedure. It is read in stomate_initialize using a getin_p but indeed the value is not correctly transmitted to the stomate_main procedure. There is also a stomate_Cforcing_name in constantes_var. 
    187171 
     
    194178Albert: done in r2910. 
    195179 
     180== Bug report on LIGHTNING_FILE by F. Maignan on 2015/08/24 
     181LIGHTNING_FILE should not be read if FIRE_DISABLE=y. [[BR]] 
     182Albert: done in r2911. 
     183 
    196184=== '''To be corrected''' === 
    197 * 2015/08/24 
    198  - LIGHTNING_FILE should not be read if FIRE_DISABLE=y. Albert: done in r2911. 
    199185* 2015/08/21 
    200186 - GRAZING_MAP should not be read if grassland management is not activated. 
     
    202188 
    203189 
    204 == Tao == 
     190== Bug report by T. Wang == 
    205191 
    206192There is a small bug in our MICT version that might induce the failure of some point simulations. In subroutine enerbil_flux of enerbil.f90: 
     
    230216Albert: done in r2912. 
    231217 
    232 == Chao == 
     218== Bug report by C. Yue == 
    233219 
    234220Please put these changes in the '''src_stomate/Grassland_Management.f90'''. They're used to protect the division-by-zero from happening. But I don't think this correction is related negative fuel problem. But it could lead to Nan value in fuel if you activate the GM (which is not your case as I checked the run.def you sent before).