Opened 9 years ago
Closed 9 years ago
#90 closed enhancement (fixed)
clean up in modipsl/util
Reported by: | jgipsl | Owned by: | jgipsl |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | scripts | Version: | |
Keywords: | Cc: |
Description
Do anyone use following scripts in modipsl/util?
- clr_make
- ins_script
- ins_post
- w_i_e
- w_i_p
- env_make
Otherwise I propose to remove them.
Keeping scripts which probably do not work any more risk to confuse the users of modipsl.
Change History (5)
comment:1 Changed 9 years ago by sdipsl
comment:2 Changed 9 years ago by mafoipsl
w_i_e is used in ORCHIDEE and in IOIPSL for IPSLCM5A.
comment:3 Changed 9 years ago by jgipsl
- Owner changed from igcmg to jgipsl
- Status changed from new to assigned
Ok. I didn't see that. w_i_e is used by all AA_make files, which means also for new configurations using IOIPSL. w_i_e is only used to type following information, for example at ada:
**************************************************************** INFO - This Makefile is for host type : ada INFO - Host used has type : ada ****************************************************************
or at a local host:
**************************************************************** INFO - This Makefile is for host type : gfortran INFO - Host used has type : linux **************************************************************** WARNING - This Makefile may not be compatible whith the host ! ****************************************************************
Personally I do not think this information is useful, specially as it is swallowed in all information from the compiling. In all cases it is only a warning and the model compiles independently from that.
I propose to remove the usage of w_i_e:
w_i_e is set in AA_make.gdef, it is not hard coded into IOIPSL or ORCHIDEE. This is simply done from AA_make.gdef by removing the lines:
WW_h_t = $(shell cat $(UTIL_DIR)/.host_target) WW_h_w = $(shell $(UTIL_DIR)/w_i_h) WW_t_e = $(shell $(UTIL_DIR)/w_i_e $(WW_h_t) $(WW_h_w)) ifeq "$(WW_t_e)" "NO" $(error ) endif
comment:4 Changed 9 years ago by jgipsl
Test de compilation fait avec cette nettoyage pour config IPSLCM5A sur ada.
comment:5 Changed 9 years ago by jgipsl
- Resolution set to fixed
- Status changed from assigned to closed
I don't think anyone use it.
+1 to clean that up.