Custom Query (116 matches)

It reads on line 792 as

      if (data_ni.isEmpty())
      {
        data_ni.setValue((data_dim == 1) ? (ni.getValue() * nj.getValue()) : ni.getValue());
      }

which is obviously wrong (set values should be reversed). This actually causes segmentation violation when nj is not set and data_dim==1; and this should lead to underestimated allocation when data_dim==2

Assume you want to convert an energy flux in mass flux using an XIOS filter :

   <field id="tran"    name="tran"  unit="kg m-2 s-1"> evptr / 2.5008E+6</field>

It would be smarter to use (and re-use) a named constant, such as in :

 <variable_definition>
    <variable id="coeffl"  type="float">2.5008E+6</variable>
  </variable_definition>

    <field_definition id="field_definition" operation="instant" prec="4">
        <field id="tran"    name="tran"  unit="kg m-2 s-1"> evptr / coeffl </field>
    </field_definition>

However, this does not work

In domain.cpp, for the case of a rectilinear domain, completeLonLatClient uses lonvalue_1D with an implicit assumption that the distribution also is recti-linear (i.e. that each MPI tasks does process a rectangle in the lat-lon space)

This does not apply when data_dim=1 and the distribution follows another scheme.

The attached version of domain.cpp, domain_new.cpp, is a proposal for an alternate convention in that case : lonvalue_1d and latvalue_1d are then interpreted as providing arrays which are parallel to the data arrays (which is more intuitive in that data_dim=1 case)