xios test suite results file

[mhedley]

i think this applies to both xios-3.0-beta and trunk, but only properly tested on xios-3.0-beta

the checkfile.def test file for test_domain_algo
https://forge.ipsl.jussieu.fr/ioserver/browser/XIOS3/branches/xios-3.0-beta/xios_test_suite/TEST_SUITE/test_domain_algo/checkfile.def#L5

lists an expected output file that is not produced by the test

i think that the test is running correctly, and that this file is not produced

i propose a change, removing line #5

atm_output_domain_transformation_zoom.nc

see attached
xios-3.0-beta-test-run-pass
demonstrating the change, compared to the failing run
xios-3.0-beta-test-run-fail

1. is this a valid change to propose?
2. should it apply to both xios-3.0-beta and trunk?

[mhedley]

xios-3.0-beta-test-run-pass

[mhedley]

xios-3.0-beta-test-run-fail

[jderouillat]

1. It is.

On our side, no error is reported because something is missing when we check files.
For now, there is 3 cases :

• if : the file has been generated and the reference file exists
• else if : the file has been generated
• else if : the reference file exists

I'll add a else to detect errors in checkfile.def

2. It concerns both.

The test suite is applied automatically on the trunk which is a development/integration branch (with online reports). But in some case, the test suite can be applied by hand on "stable" branches as xios-3.0-beta.

[jderouillat]

The creation of files defined in checkfile.def has been added in ​XIOS3 and ​XIOS2.

atm_output_domain_transformation_zoom.nc is no more tested in XIOS3, where the zoom transformation is replaced by the extract transformation.