Opened 13 years ago

Closed 13 years ago

#44 closed defect (fixed)

Smoothfile : first access

Reported by: mafoipsl Owned by: somebody
Priority: minor Milestone: libIGCM_v1.11
Component: system Version:
Keywords: SmoothFile Cc:

Description

For Smooth file, first access is always set for Period=1 :

383	    eval ret=$( IGCM_SmoothModulo ${!SmoothDef} ${!CumulPeriod} )
384	    if ( [ X${ret} = Xtrue ] || [ ${Period} -eq 1 ] ) ; then
385	        IGCM_sys_Get ${file_in} ${file_out}

It should be preferable to use min value of Smoothfile parameters (!StringModulo : [min]:[modulo:][max]) and CumulPeriod instead of Period. Need a new function : IGCM_SmoothMin to find min value.

More information on SmoothFile : #8.

Change History (4)

comment:1 Changed 13 years ago by sdipsl

  • Milestone changed from libIGCM_v1.91 to libIGCM_v1.11

comment:2 Changed 13 years ago by sdipsl

Also if CumulPeriod? is greater than max in [min]:[modulo:][max] there is no point to get the data.

comment:3 Changed 13 years ago by sdipsl

if ( [ X${ret} = Xtrue ]
[ ${Period} -eq 1 ] ) ; then

could then be replace by

if ( [ X${ret} = Xtrue ] || ( [ ${Period} -eq 1 ] && [ ${CumulPeriod} -ge ${min} ] && [ ${CumulPeriod} -le ${max} ) ) ; then
   IGCM_sys_Get ${file_in} ${file_out}

comment:4 Changed 13 years ago by sdipsl

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.