Changeset 2236 for trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm

Timestamp:

04/01/19 16:57:40 (5 years ago)

Author:

nanardon

Message:

Don't maintains attributes list in SQL table anymore

This patch remove the attributes_list table which contain the list of
allowed attributes on object.
The list of attributes is now only in the application side.

File:

• trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm (modified) (3 diffs)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm

@@ -19 +19 @@
 
 =cut
-
-sub _attributes_table { $_[0]->_object_table . '_attributes_list' }
 
 # Write extend attribute table
@@ -248 +246 @@
         foreach my $var (keys %{ $commons{$attr} }) {
             $info->{$attr}{$var} = $commons{$attr}{$var};
-        }
-    }
-
-    # TODO kill this code: useless since everything is declared in perl code
-    if ($class->_has_extended_attributes) {
-        if (!$base->{__cache}{$class->_object_table}{extend}) {
-            $base->{__cache}{$class->_object_table}{extend} = [];
-            my $sth = $base->db->prepare_cached(
-                sprintf(
-                    q{select canonical from %s order by canonical},
-                    $base->db->quote_identifier($class->_attributes_table),
-                )
-            );
-            $sth->execute;
-            while (my $res = $sth->fetchrow_hashref) {
-                push(@{$base->{__cache}{$class->_object_table}{extend}},
-                        $res->{canonical});
-            }
-        }
-        foreach (@{$base->{__cache}{$class->_object_table}{extend}}) {
-            #$base->log(LA_DEBUG, 'Attribute %s for %s not declared in code', $_, $class->type) if(!exists($info->{$_}));
-            $info->{$_} ||= {};
         }
     }
@@ -1246 +1222 @@
 }
 
-=head2 register_attribute
-
-Register attribute into base
-
-=cut
-
-sub register_attribute {
-    my ($class, $base, $attribute, $comment) = @_;
-
-    $class->is_registered_attribute($base, $attribute) and do {
-        $base->log(LA_ERR, "The attribute $attribute already exists");
-        return;
-    };
-    my $sth = $base->db->prepare(
-        sprintf(q{
-            insert into %s (canonical, description)
-            values (?,?)
-            }, $class->_attributes_table)
-    );
-    my $res = $sth->execute($attribute, $comment);
-}
-
-=head2 is_registered_attribute ($base, $attribute)
-
-Return true is attribute is registered into base
-
-=cut
-
-sub is_registered_attribute {
-    my ($class, $base, $attribute) = @_;
-
-    my $sth = $base->db->prepare(
-        sprintf(q{
-            select 1 from %s where canonical = ?
-            }, $class->_attributes_table
-        )
-    );
-    $sth->execute($attribute);
-    my $res = $sth->fetchrow_hashref;
-    return $res ? 1 : 0;
-}
-
-=head2 list_registered_attributes
-
-Return the list for all registered attribute
-
-=cut
-
-sub list_registered_attributes {
-    my ($class, $base) = @_;
-
-    my $sth = $base->db->prepare(
-        sprintf(q{
-            select canonical from %s
-            }, $class->_attributes_table
-        )
-    );
-    $sth->execute();
-    my @attrs = ();
-
-    while (my $res = $sth->fetchrow_hashref) {
-        push(@attrs, $res->{canonical});
-    }
-    return @attrs;
-}
-
-
-=head2 get_attribute_comment $base, $attribute)
-
-Return comment for C<$attribute>
-
-=cut
-
-# TODO: get_attribute_comment($attr, $base) { $base ||= $self->base ...
-
-sub get_attribute_comment {
-    my ($class, $base, $attribute) = @_;
-    $base->attribute($class->type, $attribute) or do {
-        $base->log(LA_ERR, "The attribute $attribute does not exists");
-        return;
-    };
-    my $sth = $base->db->prepare(
-        sprintf(q{
-            select description from %s
-            where canonical = ?
-            }, $class->_attributes_table)
-    );
-    $sth->execute($attribute);
-    if (my $res = $sth->fetchrow_hashref) {
-        $sth->finish;
-        return $res->{description};
-    } else {
-        return;
-    }
-}
-
-=head2 set_attribute_comment ($base, $attribute, $comment)
-
-Set comment to attribute
-
-=cut
-
-sub set_attribute_comment {
-    my ($class, $base, $attribute, $comment) = @_;
-
-    my $attr = $base->attribute($class->type, $attribute) or do {
-        $base->log(LA_ERR, "The attribute $attribute does not exists");
-        return;
-    };
-    $attr->{inline} and do {
-        $base->log(LA_ERR,
-            "Cannot set comment to inline attribute, sorry, blame the author !"
-        );
-        return;
-    };
-    my $sth = $base->db->prepare(
-        sprintf(q{
-            update %s set description = ?
-            where canonical = ?
-            }, $class->_attributes_table)
-    );
-    my $res = $sth->execute($comment, $attribute);
-}
-
 sub _update_aliases_ptr {
     my ($self) = @_;