Changeset 7328

Timestamp:

2016-11-24T14:20:15+01:00 (7 years ago)

Author:

isabella

Message:

Added parameters in namelist
, plus few more corrections

File:

• branches/UKMO/dev_r5518_pcbias_ipc/NEMOGCM/NEMO/OPA_SRC/ASM/bias.F90 (modified) (12 diffs)

branches/UKMO/dev_r5518_pcbias_ipc/NEMOGCM/NEMO/OPA_SRC/ASM/bias.F90

@@ -134 +134 @@
       & fctamp,               &  !: amplification factor for T if inertial
       & rn_maxlat_bias,       &  !: Max lat for latitudinal ramp
-      & rn_minlat_bias           !: Min lat for latitudinal ramp
+      & rn_minlat_bias,       &  !: Min lat for latitudinal ramp
+      & zwgt,                 &  !: weight for IPC
+      & ztscale                  !: decay rate for IPC
 
    LOGICAL,  PRIVATE :: lalloc
@@ -224 +226 @@
          & cn_bias_tot, cn_bias_asm, cn_dir, sn_tbias_ofl, sn_sbias_ofl,  &
          & ln_bsyncro, fctamp, rn_maxlat_bias, rn_minlat_bias,            &
-         & nn_bias_itwrt, ln_itdecay, ln_incpc
+         & nn_bias_itwrt, ln_itdecay, ln_incpc, ztscale, zwgt
  
 
@@ -284 +286 @@
     WRITE(numout,*) '     evolve pcbias at each timestep ln_itdecay     = ',ln_itdecay
     WRITE(numout,*) '     incremental press. correction  ln_incpc       = ',ln_incpc
+    WRITE(numout,*) '     incremental press. correction  zwgt           = ',zwgt
+    WRITE(numout,*) '     incremental press. correction  ztscale        = ',ztscale
          WRITE(numout,*) '  Parameters for parition of bias term '
          WRITE(numout,*) '                                    fb_t_rlx       = ',fb_t_rlx
@@ -306 +310 @@
             &   CALL ctl_stop (' lk_dtatem, lk_dtasal and lk_tradmp need to be true with ln_bias_rlx' )
 
+         IF ( (.NOT. ln_itdecay) .AND. ln_incpc) &   
+            &   CALL ctl_stop (' if you set ln_incpc to .true. then you need to set ln_itdecay to .true. as well' )
+
       ENDIF
       IF( .NOT. ln_bias ) RETURN
@@ -328 +335 @@
                                       sbias_asm_out(jpi,jpj,jpk), &  
                                       tbias_p_out(jpi,jpj,jpk),   &              
-                                      sbias_p_out(jpi,jpj,jpk),   &
-                                      tbias_i_out(jpi,jpj,jpk),   &  
-                                      sbias_i_out(jpi,jpj,jpk)   )
+                                      sbias_p_out(jpi,jpj,jpk)    )
 
          IF( ln_bias_rlx ) ALLOCATE(  tbias_rlx(jpi,jpj,jpk),     &
@@ -340 +345 @@
             &                         sbias_asm_stscale(jpi,jpj,jpk), &
                                       tbias_asm_stscale_out(jpi,jpj,jpk), &
-                                      sbias_asm_stscale_out(jpi,jpj,jpk))
+                                      sbias_asm_stscale_out(jpi,jpj,jpk), &
+                                      tbias_i_out(jpi,jpj,jpk),   &  
+                                      sbias_i_out(jpi,jpj,jpk)   )
 
          lalloc = .TRUE.
@@ -432 +439 @@
                   CALL ctl_stop( 'Bias assim variables not found in ',cn_bias_tot )
                ENDIF
-
-
-               IF ( ln_incpc ) THEN
-                  IF(lwp) WRITE(numout,*) 'Reading short time scale bias correction fields for bias asm from file ',cn_bias_tot
-                  IF( iom_varid( numbias_tot, 'tbias_asm_stscale' ) > 0 ) THEN
-                     ! Get the T and S bias data
-                     CALL iom_get( numbias_tot, jpdom_autoglo, 'tbias_asm_stscale', tbias_asm_stscale )
+            ENDIF
+
+            IF ( ln_incpc .and. .not.ln_bsyncro ) THEN
+               IF(lwp) WRITE(numout,*) 'Reading short time scale bias correction fields for bias asm from file ',cn_bias_tot
+               IF( iom_varid( numbias_tot, 'tbias_asm_stscale' ) > 0 ) THEN
+                  ! Get the T and S bias data
+                  CALL iom_get( numbias_tot, jpdom_autoglo, 'tbias_asm_stscale', tbias_asm_stscale )
                      CALL iom_get( numbias_tot, jpdom_autoglo, 'sbias_asm_stscale', sbias_asm_stscale )
-                  ELSE
+               ELSE
                      CALL ctl_stop( 'Short time scale bias assim variables not found in ',cn_bias_tot )
-                  ENDIF
-               ENDIF  
-
-            ENDIF
+               ENDIF
+            ENDIF  
 
 
@@ -577 +582 @@
       REAL(wp)            ::   ztfrac, ztsday
       REAL(wp)            ::   zfrac, zfrac1 ! temporal weights for inst pcbias (names could be changed)
-      REAL(wp)            ::   ztscale       ! reduce the inst pcbias by this amount per 24 hours
-      REAL(wp)            ::   zwgt          ! Weight for the inst pcorr term
       REAL(wp)            ::   zdecay        ! used in inst pcorr
       REAL(wp), DIMENSION(jpi,jpj) :: zcof1, zcof2
@@ -593 +596 @@
       tbias_i(:,:,:) = 0.0_wp
       sbias_i(:,:,:) = 0.0_wp
-
-      ztscale = 0.1_wp
-      zwgt    = 0.8_wp
 
       IF ( ln_bias_asm ) THEN
@@ -604 +604 @@
             &                              fbcoef(:,:)   * fb_t_asm_max )
          zcof2(:,:) = ( 1.0_wp - fbcoef(:,:) ) * fb_p_asm
-      
+     
+
          IF ( ln_itdecay ) THEN   !decay the pressure correction at each time step
     
@@ -902 +903 @@
          tbias_p_out(:,:,:)   = tbias_p(:,:,:)
          sbias_p_out(:,:,:)   = sbias_p(:,:,:)
-         tbias_i_out(:,:,:)   = tbias_i(:,:,:)
-         sbias_i_out(:,:,:)   = sbias_i(:,:,:)
+         IF (ln_incpc) THEN
+            tbias_i_out(:,:,:)   = tbias_i(:,:,:)
+            sbias_i_out(:,:,:)   = sbias_i(:,:,:)
+         ENDIF
       ENDIF
 
@@ -1033 +1036 @@
          CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_asm' , sbias_asm_out )   
          CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'tbias_p'   , tbias_p_out )
-         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_p'   , sbias_p_out )
-         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'tbias_i'   , tbias_i_out )
-         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_i'   , sbias_i_out )          
+         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_p'   , sbias_p_out )         
       ENDIF
 
       IF ( ln_incpc ) THEN
          CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'tbias_asm_stscale' , tbias_asm_stscale_out )   
-         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_asm_stscale' , sbias_asm_stscale_out )   
+         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_asm_stscale' , sbias_asm_stscale_out ) 
+         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'tbias_i'   , tbias_i_out )
+         CALL iom_rstput( nn_bias_itwrt, nn_bias_itwrt, numbias_tot, 'sbias_i'   , sbias_i_out )   
       ENDIF