New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
Custom Query – NEMO

Custom Query (2547 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (28 - 30 of 2547)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
Ticket Owner Reporter Resolution Summary
#762 nemo gm fixed BUG in wind stress over ice when NEC computer + CORE bulk formulae
Description

This critical bug only concerns NEC users having sea-ice defined (key_lim3 or key_lim3)

sbcblk_core.F90 : the following lines can be found in the blk_ice_core routine:

      ! ----------------------------------------------------------------------------- !
      !    Wind components and module relative to the moving ocean ( U10m - U_ice )   !
      ! ----------------------------------------------------------------------------- !
      SELECT CASE( cd_grid )
      CASE( 'I' )                  ! B-grid ice dynamics :   I-point (i.e. F-point with sea-ice indexation)
         !                           and scalar wind at T-point ( = | U10m - U_ice | ) (masked)
#if defined key_vectopt_loop
!CDIR COLLAPSE
#endif
!CDIR NOVERRCHK
         DO jj = 2, jpjm1
            DO ji = 2, jpim1   ! B grid : NO vector opt
               ! ... scalar wind at I-point (fld being at T-point)
               zwndi_f = 0.25 * (  sf(jp_wndi)%fnow(ji-1,jj  ,1) + sf(jp_wndi)%fnow(ji  ,jj  ,1)   &
                  &              + sf(jp_wndi)%fnow(ji-1,jj-1,1) + sf(jp_wndi)%fnow(ji  ,jj-1,1)  ) - pui(ji,jj)

Due to an out-of-bound problem (see ticket #380) the loop over ji index is always from 2 to jpim1.

When key_vectopt_loop is defined (always the case on vector computer such as NEC), the NEC compiler instruction !CDIR COLLAPSE is active.

Therefore the two DO-loops on jj and ji are collapsed. The computation is then done from jpj +2 to (jpj-1)*(jpi-2) whereas it should be done until [ (jpj-1)*jpi -1 ].

In ORCA2-LIM (same for ORCA05, 025...), this means that the lines jpj-1 and half the line jpj-2 will not be computed ! The stress at the surface of the ice will be zero there, resulting in a strange ice thinkness pattern at the north fold....

The solution is simply to remove the following three lines :

#if defined key_vectopt_loop
!CDIR COLLAPSE
#endif

This problem concerns v3.2 and v3.3beta.

In v3.1, the out-of-bound problem was there (ticket #380) and so not this huge zeroing of ice stress.

Gurvan.

PS: many thanks to Frederic Dupont who was the first to point out the ice anomalies near the north fold in the reference ORCA2-LIM simulation performed with CORE2 forcing

#783 nemo rblod fixed domzgr follow-on
Description

LIne 507, I should be

bathy(:,:) = MAX( zhmin , bathy(:,:) ) ! min=zhmin over the oceans

rather than

bathy(:,:) = MIN( zhmin , bathy(:,:) ) ! min=zhmin over the oceans

unless we want to come back to bi-level ocean models...

#788 nemo molines fixed dupplicate code in obc_ini
Description

In obc_ini, the following bloc of code is duplicated, thus introducing an error in the value of obcsurftot ...

      IF( lp_obc_west ) THEN ! ... West open boundary lateral surface
         DO ji = niw0, niw1
            DO jj = 1, jpj 
               obcsurftot = obcsurftot+hu(ji,jj)*e2u(ji,jj)*uwmsk(jj,1) * MAX(obctmsk(ji,jj),obctmsk(ji+1,jj) )
            END DO
         END DO
      END IF
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
Note: See TracQuery for help on using queries.