Context

The use of Charnock coefficient from a wave model has been included to sbcblk_algo_ecmwf.F90 during the December merge r14020. It has been deleted in a next merge ( not anymore in r14116)

Analysis

...

Fix

Modify sbcblk_algo_ecmwf.F90

USE sbcwave, ONLY : charn ! wave module

Relace: z0 = charn0_ecmwf*u_star*u_star/grav + 0.11_wp*znu_a/u_star

by:

IF (ln_charn) THEN ! Charnock value if wave coupling

z0 = charn*u_star*u_star/grav + 0.11_wp*znu_a/u_star

ELSE

z0 = charn0_ecmwf*u_star*u_star/grav + 0.11_wp*znu_a/u_star

ENDIF

Replace: z0 = MIN( ABS( alpha_M*ztmp1 + charn0_ecmwf*ztmp2/grav ) , 0.001_wp)

by:

IF (ln_charn) THEN ! Charnock value if wave coupling

z0 = MIN( ABS( alpha_M*ztmp1 + charn*ztmp2/grav ) , 0.001_wp)

ELSE

z0 = MIN( ABS( alpha_M*ztmp1 + charn0_ecmwf*ztmp2/grav ) , 0.001_wp)

ENDIF

Context

wave number has to be read in an external wave forcing file if the Qiao parametrization for surface mixing is activated and a wave model is not coupled

Analysis

...

Fix

Modification in sbcwave.F90 Replace:

IF( .NOT. cpl_wnum ) THEN by IF( ln_zdfswm .AND. .NOT. cpl_wnum )

And add:

USE zdf_oce, ONLY : ln_zdfswm

! Read wave number if needed (ln_zdfswm=T) IF( .AND. .NOT. cpl_wnum ) THEN !==wavenumber==!

CALL fld_read( kt, nn_fsbc, sf_wn ) ! read wave parameters from external forcing wnum( : , : ) = sf_wn(1)%fnow(:,:,1) * tmask(:,:,1)

ENDIF

Context & Analysis

when using makenemo -e option to use a custom modified src directory instead of MY_SRC, Fmake_WORK.sh script will first create symlinks from the custom dir to the MY_SRC dir, then from MY_SRC dir to WORK dir.

If by any misfortune you have already another modified version of the same source file in MY_SRC dir, this file will be overwritten by the symlink from the custom dir, which can be disappointing.

Recommendation

Instead of doing a symlink of symlink from custom dir -> MY_SRC dir -> WORK dir, just simply do a symlink from custom dir to WORK dir