New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
Ticket Diff – NEMO

Changes between Initial Version and Version 4 of Ticket #1734


Ignore:
Timestamp:
2017-09-28T19:49:42+02:00 (7 years ago)
Author:
nicolasmartin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1734

    • Property Owner changed from nemo to jamesharle
    • Property Cc jamesharle added
    • Property Status changed from new to assigned
  • Ticket #1734 – Description

    initial v4  
    1 = Context = 
     1= Context 
     2 
    23  NEMO_3.6_STABLE with straight BDY (as old OBC) and rim width > 1 produce a Seg. fault due to out of bound on dta_global2 array 
    34 
    4 = Analysis = 
     5= Analysis 
     6 
    57  In this case bdy data are organized as a vector with all the data within the rim put sequentially from the outermost to innermost. Therefore it seems to me that in bdyini.F90 we must have 
    68 
    7 {{{ 
     9{{{#!f 
    810jpbdtas = MAX(jpbdtas, (nbdyend - nbdybeg + 1) * nn_rimwidth(ib_bdy)  ) 
    911}}} 
    1012 
    11 instead of 
     13  instead of 
    1214 
    13 {{{ 
     15{{{#!f 
    1416jpbdtas = MAX(jpbdtas, (nbdyend - nbdybeg + 1)) 
    1517}}} 
     18 
    1619  Further more, the allocation of dta_global2 should be (not tested): 
    17 {{{ 
     20 
     21{{{#!f 
    1822ALLOCATE( dta_global2(jpbdtas, 1, jpk) )  
    1923}}} 
    2024 
    21 instead of 
     25  instead of 
    2226 
    23 {{{ 
     27{{{#!f 
    2428ALLOCATE( dta_global2(jpbdtas, nrimmax, jpk) ) 
    2529}}} 
    26 = Fix = 
     30 
     31= Fix 
     32 
    2733The only change of jpbdtas as sugested above fix the problem of outbound.