Changes between Version 1 and Version 2 of Ticket #1928
- Timestamp:
- 2017-09-27T19:34:32+02:00 (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1928
- Property Status changed from new to assigned
- Property Owner nemo deleted
-
Ticket #1928 – Description
v1 v2 1 = Context =1 = Context 2 2 ldf_slp_triad routine (Griffies isopycnal mixing) 3 3 4 = Analysis = 5 1) Vertical density gradient computation makes use of zalbet(:,:,:) array and scalar zbeta0, both of which being undefined. 4 = Analysis 5 6 1. Vertical density gradient computation makes use of zalbet(:,:,:) array and scalar zbeta0, both of which being undefined. 6 7 7 8 {{{#!f 8 9 zdzrho_raw = ( - zalbet(ji,jj,jk) * zdkt + zbeta0*zdks ) / e3w_n(ji,jj,jk+kp) 9 10 }}} 10 2) I think that something is wrong in the switch from Lemarié more compact stencil and original scheme, e.g. in the use of rn_sw_triad (0,1) here: 11 12 2. I think that something is wrong in the switch from Lemarié more compact stencil and original scheme, e.g. in the use of rn_sw_triad (0,1) here: 11 13 12 14 {{{#!f … … 16 18 & * 2._wp * ABS( 0.5_wp - kp - ( 0.5_wp - jp ) * SIGN( 1._wp , zdyrho(ji,jj+jp,jk,1-jp) ) ) 17 19 }}} 18 Shouldn't it be: 20 21 Shouldn't it be: 19 22 20 23 {{{#!f … … 24 27 & * 2._wp * ABS( 0.5_wp - kp - ( 0.5_wp - jp ) * SIGN( 1._wp , zdyrho(ji,jj+jp,jk,1-jp) ) ) 25 28 }}} 26 = Fix =27 1)28 29 30 = Fix 31 32 1. \\ 29 33 {{{#!f 30 34 zdzrho_raw = ( - rab_b(ji,jj,jk+kp,jp_tem) * zdkt + rab_b(ji,jj,jk+kp,jp_sal)*zdks ) / e3w_n(ji,jj,jk+kp) 31 35 }}} 32 2) Given above if confirmed (this part of the code is obscure to me) 36 37 2. Given above if confirmed (this part of the code is obscure to me)