New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
Ticket Diff – NEMO

Changes between Version 1 and Version 2 of Ticket #1928


Ignore:
Timestamp:
2017-09-27T19:34:32+02:00 (7 years ago)
Author:
nicolasmartin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1928

    • Property Status changed from new to assigned
    • Property Owner nemo deleted
  • Ticket #1928 – Description

    v1 v2  
    1 = Context = 
     1= Context 
    22ldf_slp_triad routine (Griffies isopycnal mixing) 
    33 
    4 = Analysis = 
    5 1) Vertical density gradient computation makes use of zalbet(:,:,:) array and scalar zbeta0, both of which being undefined. 
     4= Analysis 
     5 
     61. Vertical density gradient computation makes use of zalbet(:,:,:) array and scalar zbeta0, both of which being undefined. 
    67 
    78{{{#!f 
    89zdzrho_raw = ( - zalbet(ji,jj,jk) * zdkt + zbeta0*zdks ) / e3w_n(ji,jj,jk+kp) 
    910}}} 
    10 2) I think that something is wrong in the switch from Lemarié more compact stencil and original scheme, e.g. in the use of rn_sw_triad (0,1) here: 
     11 
     122. I think that something is wrong in the switch from Lemarié more compact stencil and original scheme, e.g. in the use of rn_sw_triad (0,1) here: 
    1113 
    1214{{{#!f 
     
    1618&            * 2._wp * ABS( 0.5_wp - kp - ( 0.5_wp - jp ) * SIGN( 1._wp , zdyrho(ji,jj+jp,jk,1-jp) )  ) 
    1719}}} 
    18 Shouldn't it be: 
     20 
     21 Shouldn't it be: 
    1922 
    2023{{{#!f 
     
    2427&            * 2._wp * ABS( 0.5_wp - kp - ( 0.5_wp - jp ) * SIGN( 1._wp , zdyrho(ji,jj+jp,jk,1-jp) )  ) 
    2528}}} 
    26 = Fix = 
    27 1) 
    2829 
     30= Fix 
     31 
     321. \\ 
    2933{{{#!f 
    3034zdzrho_raw = ( - rab_b(ji,jj,jk+kp,jp_tem) * zdkt + rab_b(ji,jj,jk+kp,jp_sal)*zdks ) / e3w_n(ji,jj,jk+kp) 
    3135}}} 
    32 2) Given above if confirmed (this part of the code is obscure to me) 
     36 
     372. Given above if confirmed (this part of the code is obscure to me)